mcf: remove lifetime from PasswordHashRef#2116
Merged
Conversation
NOTE: breaking change Changes the `PasswordHashRef` type into a `repr(transparent)` newtype for `str`, constructing it as `&PasswordHashRef` using an unsafe pointer cast which is only invoked after first validating it's well-formed. This makes it possible to impl `Borrow<PasswordHashRef>` on `PasswordHash` and `ToOwned` on `PasswordHashRef`. `AsRef` and `Deref` impls have been added to `PasswordHash` for obtaining a `&PasswordHashRef`, and the inherent methods which were duplicated on both `PasswordHashRef` and `PasswordHash` have been removed, following a similar pattern to `str`/`String`. The `PasswordHash::as_mcf_hash_ref` method has been removed in favor of using any of `AsRef`, `Borrow`, or `Deref` to do the conversion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: breaking change
Changes the
PasswordHashReftype into arepr(transparent)newtype forstr, constructing it as&PasswordHashRefusing an unsafe pointer cast which is only invoked after first validating it's well-formed.This makes it possible to impl
Borrow<PasswordHashRef>onPasswordHashandToOwnedonPasswordHashRef.AsRefandDerefimpls have been added toPasswordHashfor obtaining a&PasswordHashRef, and the inherent methods which were duplicated on bothPasswordHashRefandPasswordHashhave been removed, following a similar pattern tostr/String.The
PasswordHash::as_mcf_hash_refmethod has been removed in favor of using any ofAsRef,Borrow, orDerefto do the conversion.