Merged
Conversation
Closes #2133 `Base64ShaCrypt` is, as far as I can tell, the standard Base64 alphabet used by all `crypt(3)` hashes. The only exception is `bcrypt` which uses a completely different alphabet (`./A-Za-z0-9`). As far as I can tell all algorithms that actually use the `./0-9A-Za-z` alphabet do so with the little endian packing implemented in `Base64ShaCrypt`. I'm uncertain about the provenance of the test vectors for `Base64Crypt` but as far as I can tell it's actually a non-standard packing for this particular alphabet. As such, this deprecates `Base64Crypt`, steering people towards `Base64ShaCrypt` for now. Perhaps in the future we can find better names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2133
Base64ShaCryptis, as far as I can tell, the standard Base64 alphabet used by allcrypt(3)hashes. The only exception isbcryptwhich uses a completely different alphabet (./A-Za-z0-9).As far as I can tell all algorithms that actually use the
./0-9A-Za-zalphabet do so with the little endian packing implemented inBase64ShaCrypt. I'm uncertain about the provenance of the test vectors forBase64Cryptbut as far as I can tell it's actually a non-standard packing for this particular alphabet.As such, this deprecates
Base64Crypt, steering people towardsBase64ShaCryptfor now. Perhaps in the future we can find better names.