Add support for context specific fields with default values #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
reviewed
Nov 18, 2021
tarcieri
reviewed
Nov 18, 2021
…se hex literal comment feature to place dumpasn1-generated description inline in test cases.
tarcieri
reviewed
Nov 19, 2021
Comment on lines
+251
to
+253
| // onlySomeReasons [3] ReasonFlags OPTIONAL, | ||
| //#[asn1(context_specific="3", optional="true", tag_mode="IMPLICIT")] | ||
| //pub only_some_reasons: Option<ReasonFlags<'a>>, |
Member
There was a problem hiding this comment.
Is there a reason why this is commented out?
Contributor
Author
There was a problem hiding this comment.
The types for the commented out fields are not in the main x509 repo yet. Replicating those here seemed heavier than the value they would add to the example. The structure without the comments will land as x509 bits are pushed.
tarcieri
reviewed
Nov 19, 2021
tarcieri
approved these changes
Nov 19, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.