x509: derive all implementations #422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
tarcieri
reviewed
Feb 11, 2022
tarcieri
approved these changes
Feb 11, 2022
Member
|
@carl-wallace mind taking a look at this one? |
| /// [[3: -- If present, version MUST be v3 -- | ||
| /// extensions [3] Extensions{{CertExtensions}} OPTIONAL | ||
| /// ]], ... } | ||
| /// TBSCertificate ::= SEQUENCE { |
Contributor
There was a problem hiding this comment.
The brackets in comments should be escaped to make cargo doc happy.
Contributor
Author
There was a problem hiding this comment.
They are in a text block like they should be in order to avoid this problem. No escaping is needed.
Member
There was a problem hiding this comment.
Yeah, we should really add a test that cargo doc completes without warnings
tarcieri
requested changes
Feb 11, 2022
Member
tarcieri
left a comment
tarcieri
left a comment
There was a problem hiding this comment.
Please add back the schema comment on TbsCertificate::version
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
The remaining types had interrelated dependencies and needed to be performed as a set. These types are: * DistributionPoint * DistributionPointName * IssuingDistributionPoint Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
npmccallum
force-pushed
the
newderive
branch
from
18f11e8 to
277715b
Compare
Contributor
Author
|
@tarcieri Rather than just copy/pasting schema into the version field comment, instead I wrote a proper comment explaining the full meaning of the situation. |
Member
|
@npmccallum fantastic! |
tarcieri
approved these changes
Feb 11, 2022
Contributor
Author
|
@tarcieri Ready to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR derives implementations for x509 types. I have taken great care to ensure that every commit passes all existing tests. This PR is the early portion of the larger #414 PR.