Additional OID DB improvments #453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was a nice idea to sort by kind. But expanding to other data sources makes this cumbersome. Drop this notion. Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
tarcieri
reviewed
Feb 28, 2022
tarcieri
reviewed
Feb 28, 2022
tarcieri
approved these changes
Feb 28, 2022
We now have a parser for ASN.1 OID definitions. By using this against RFC 5280, we get more definitions. This also provides a re-usable framework for other RFCs. Additionally, the definitions are now sorted by name. This should decrease code churn. Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
tarcieri
approved these changes
Feb 28, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.