Skip to content

Conversation

@npmccallum
Copy link
Contributor

This contains just the CRL portion of #462. I made sure to give @carl-wallace the author's credit.

One remaining question I have is why these are in the crl module. Are these types used in extensions? Or are they disconnected data types? If the latter, crl is probably the best place for them.

@tarcieri FYI

@carl-wallace
Copy link
Contributor

I don't know what you mean by "these". The definitions in crl.rs are associated with crl processing. I will close #462 and keep eye on this repo and align higher level bits as this catches up.

@npmccallum
Copy link
Contributor Author

@carl-wallace I mean the types in the crl module in this PR. Are the crl types used in extensions?

@carl-wallace
Copy link
Contributor

No. There are only three structures: the primary CRL structure, its TBS structure and a structure fabricated from the revoked certs field of the TBS structure (as noted in the comment, for some reason the spec authors defined this structure inline). Feel free to split into smaller pieces if you prefer. Credit should probably go to Alan Smithee:-)

@npmccallum
Copy link
Contributor Author

@carl-wallace Who would use these types and how are they used?

@carl-wallace
Copy link
Contributor

See the comments in the code. https://datatracker.ietf.org/doc/html/rfc5280#section-5.1

@npmccallum
Copy link
Contributor Author

@carl-wallace The standard defines the data types and what is hopes they accomplish from the perspective of 2008. It doesn't describe how these types are actually used in 2022. I'm hoping you can fill me in on the common usage patterns.

@carl-wallace
Copy link
Contributor

these are fundamental structures. where crls are used, these are in play.

@npmccallum npmccallum force-pushed the crl branch 2 times, most recently from ae89ca6 to da30ef4 Compare March 7, 2022 20:27
@tarcieri tarcieri merged commit 89e7c04 into RustCrypto:master Mar 10, 2022
@tarcieri
Copy link
Member

Thanks!

@carl-wallace hopefully this works for your use cases, or if not, feel free to open a PR to make adjustments

@npmccallum npmccallum deleted the crl branch March 10, 2022 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants