Safe conversions between Array and [T; N]#24
Merged
Conversation
Simply bounding on `ArrayType<T> = [T; N]` is enough to accomplish this. I've verified this change against a few of our repos (e.g. `block-ciphers`, `elliptic-curve`) and it does not seem to cause any inference problems. When this bound is in place there's no need for `ArrayOps<T, N>` either.
Member
Author
|
I guess I was worried that this bound might be viral and it would require downstream bounds, but now that I can actually integration test it against large repos it doesn't seem to be causing any problems. Perhaps we could even get rid of |
tarcieri
added a commit
that referenced
this pull request
Jan 25, 2024
Continuation of the approach from #24 which replaces `ArrayOps<T, N>` bounds with `ArraySize<ArrayType<T> = [T; N]>`. Though a bit more verbose, this makes the inner type of `Array` explicit and therefore allows more safe conversions as well as making `unsafe` code easier to reason about, since the inner type is no longer implicit. This doesn't go as far as to remove the `ArrayOps` (and `SliceOps) trait(s) yet, but that should now be possible.
tarcieri
added a commit
that referenced
this pull request
Jan 25, 2024
Continuation of the approach from #24 which replaces `ArrayOps<T, N>` bounds with `ArraySize<ArrayType<T> = [T; N]>`. Though a bit more verbose, this makes the inner type of `Array` explicit and therefore allows more safe conversions as well as making `unsafe` code easier to reason about, since the inner type is no longer implicit. This doesn't go as far as to remove the `ArrayOps` (and `SliceOps`) trait(s) yet, but that should now be possible.
tarcieri
added a commit
that referenced
this pull request
Jan 27, 2024
After #24, #25, and #26, these traits don't really need to exist and have largely been replaced by safe type conversions with appropriate bounds. In lieu of `ArrayOps<T, N>` we instead can use `U: ArraySize<ArrayType<T> = [T; N]>>` as a bound, which albeit a bit more verbose concretely describes the inner type of `Array` to the compiler. The `cast_slice_(to|from)_core(_mut)` methods previously defined on the trait have been preserved, but as static methods of `Array`, making the change largely a drop in replacement. Places where they were being called as e.g. `ArrayOps::cast_slice_to_core` just need to be called as `Array::cast_slice_to_core` instead.
tarcieri
added a commit
that referenced
this pull request
Jan 27, 2024
After #24, #25, and #26, these traits don't really need to exist and have largely been replaced by safe type conversions with appropriate bounds. In lieu of `ArrayOps<T, N>` we instead can use `U: ArraySize<ArrayType<T> = [T; N]>>` as a bound, which albeit a bit more verbose concretely describes the inner type of `Array` to the compiler. The `cast_slice_(to|from)_core(_mut)` methods previously defined on the trait have been preserved, but as static methods of `Array`, making the change largely a drop in replacement. Places where they were being called as e.g. `ArrayOps::cast_slice_to_core` just need to be called as `Array::cast_slice_to_core` instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simply bounding on
ArrayType<T> = [T; N]is enough to accomplish this.I've verified this change against a few of our repos (e.g.
block-ciphers,elliptic-curve) and it does not seem to cause any inference problems.When this bound is in place there's no need for
ArrayOps<T, N>either.