Skip to content

Argon2 impl Debug#423

Merged
tarcieri merged 2 commits intoRustCrypto:masterfrom
RoDmitry:patch-1
Jun 14, 2023
Merged

Argon2 impl Debug#423
tarcieri merged 2 commits intoRustCrypto:masterfrom
RoDmitry:patch-1

Conversation

@RoDmitry
Copy link
Contributor

@RoDmitry RoDmitry commented Jun 13, 2023

No description provided.

@tarcieri
Copy link
Member

tarcieri commented Jun 13, 2023

The Argon2 struct contains a secret field which a blanket Debug impl like this will reveal.

Instead it needs a handwritten one which uses debug_struct and omits the secret field, either substituting e.g. an ellipsis "..." for the secret field or using finish_non_exhaustive.

@RoDmitry
Copy link
Contributor Author

RoDmitry commented Jun 14, 2023

Done using finish_non_exhaustive

@RoDmitry RoDmitry changed the title Argon2 derive Debug Argon2 impl Debug Jun 14, 2023
tarcieri
tarcieri approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@tarcieri tarcieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@tarcieri tarcieri merged commit eccda35 into RustCrypto:master Jun 14, 2023
@RoDmitry RoDmitry deleted the patch-1 branch June 15, 2023 10:18
@tarcieri tarcieri mentioned this pull request Jul 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarcieri tarcieri tarcieri approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RoDmitry @tarcieri