Skip to content

argon2: Add const compatibility#438

Merged
tarcieri merged 23 commits intoRustCrypto:masterfrom
C0D3-M4513R:merge-master
Aug 7, 2023
Merged

argon2: Add const compatibility#438
tarcieri merged 23 commits intoRustCrypto:masterfrom
C0D3-M4513R:merge-master

Conversation

@C0D3-M4513R
Copy link
Contributor

@C0D3-M4513R C0D3-M4513R commented Jul 3, 2023

Closes #436

newpavlov
newpavlov reviewed Jul 3, 2023
View reviewed changes
@C0D3-M4513R C0D3-M4513R requested a review from newpavlov July 3, 2023 15:49
tarcieri
tarcieri reviewed Jul 3, 2023
View reviewed changes
tarcieri
tarcieri reviewed Jul 3, 2023
View reviewed changes
tarcieri
tarcieri reviewed Jul 3, 2023
View reviewed changes
@C0D3-M4513R @tarcieri
Add tarcieri's change
524de64 
Co-authored-by: Tony Arcieri <bascule@gmail.com>
@C0D3-M4513R C0D3-M4513R requested a review from tarcieri July 3, 2023 16:04
@C0D3-M4513R
Copy link
Contributor Author

C0D3-M4513R commented Jul 3, 2023

Ah 383be35 only works in nightly... I had a rust override set for that folder

@C0D3-M4513R C0D3-M4513R changed the title Add const compatibility argon2: Add const compatibility Jul 4, 2023
@tarcieri tarcieri merged commit 5e3f574 into RustCrypto:master Aug 7, 2023
@tarcieri
Copy link
Member

tarcieri commented Aug 7, 2023 •
edited
Loading

It seems I merged this after #440 which is not compatible with these changes, namely it introduced runtime CPU feature detection which is not const-friendly.

I'm going to revert for now: #447

tarcieri added a commit that referenced this pull request Aug 7, 2023
@tarcieri
Revert "argon2: improve const compatibility (#438)"
bb63e6c 
This reverts commit 5e3f574.

These changes are incompatible with #440, which performs runtime CPU
feature detection.
tarcieri added a commit that referenced this pull request Aug 7, 2023
@tarcieri
Revert "argon2: improve const compatibility (#438)" (#447)
e19aabd 
This reverts commit 5e3f574.

These changes are incompatible with #440, which performs runtime CPU
feature detection.
@C0D3-M4513R C0D3-M4513R mentioned this pull request Aug 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarcieri tarcieri tarcieri approved these changes

@newpavlov newpavlov Awaiting requested review from newpavlov

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

argon2: const ParamsBuilder

3 participants

@C0D3-M4513R @tarcieri @newpavlov