sha-crypt: Change parameter type and make hashing infallible#500
Merged
tarcieri merged 2 commits intoRustCrypto:masterfrom May 17, 2024
Merged
sha-crypt: Change parameter type and make hashing infallible#500tarcieri merged 2 commits intoRustCrypto:masterfrom
tarcieri merged 2 commits intoRustCrypto:masterfrom
Conversation
Its type doesn't need to depend on the target architecture pointer width. Fixes RustCrypto#498.
The rounds were already checked to be sane in
`Sha{256,512}Parameters::new`.
Fixes RustCrypto#499.
tarcieri
approved these changes
May 17, 2024
Member
|
Thanks! |
Merged
tarcieri
added a commit
that referenced
this pull request
Apr 21, 2026
## Added - Implement `core::error::Error` for error types (#719) - Implement the `password-hash` crate traits (#771, #779, #806) - Dynamic `Algorithm` support (#800) - `Params` customization for `ShaCrypt` type (#801) - `ShaCrypt::SHA256` and `ShaCrypt::SHA512` (#813) - `no_alloc` support (#894) ## Changed - `rounds` parameter is now `u32` (#500) - Make hashing infallible (#500) - Bump edition to 2024; MSRV 1.85 (#563) - Switch from `rand` to `rand_core` (#720) - Use `mcf` crate for implementing Modular Crypt Format (#726, #842) - Unify `Params` type (#772) - Rename `simple` feature to `password-hash` (#776) - Migrate from `subtle` to `ctutils` (#845) - Bump `password-hash` dependency to v0.6 (#848) - Bump `sha2` to v0.11 (#872) ## Removed - `std` feature (#719)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #498.
Fixes #499.