Implement Hash on non-secret Signature and VerifyingKey types#1309
Merged
tarcieri merged 1 commit intoRustCrypto:masterfrom May 1, 2026
Merged
Implement Hash on non-secret Signature and VerifyingKey types#1309tarcieri merged 1 commit intoRustCrypto:masterfrom
tarcieri merged 1 commit intoRustCrypto:masterfrom
Conversation
tarcieri
approved these changes
Apr 27, 2026
Member
|
Hmm, those |
Member
|
@MavenRain if you merge/rebase it should take care of the test failures |
Per RustCrypto#1229: Signature and public-key types lack `Hash`, which prevents use in `HashMap` / `HashSet` keys and similar collections. - ecdsa: Signature, DER Signature, SignatureWithOid - ed25519: Signature, pkcs8::PublicKeyBytes - ed448: Signature, pkcs8::PublicKeyBytes - ml-dsa: Signature, VerifyingKey - slh-dsa: Signature, VerifyingKey Where a trivial derive works (ed25519, ed448), uses derive. Where generic bounds or upstream gaps require it, uses a manual impl over the canonical serialized bytes (`to_bytes` / `encode` / `as_bytes`), which is the natural Hash domain for these types anyway. Followups (separate PRs, blocked on upstream): - ecdsa VerifyingKey (needs PublicKey<C>: Hash in elliptic-curve) - dsa types (need BoxedUint: Hash in crypto-bigint) - lms types (need Mode-generic trait bound threading) Closes RustCrypto#1229
MavenRain
force-pushed
the
hash-on-public-types
branch
from
2685fe9 to
b3274c9
Compare
tarcieri
approved these changes
May 1, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #1229: Signature and public-key types lack
Hash, which preventsuse in
HashMap/HashSetkeys and similar collections.Where a trivial derive works (ed25519, ed448), uses derive. Where
generic bounds or upstream gaps require it, uses a manual impl over
the canonical serialized bytes (
to_bytes/encode/as_bytes),which is the natural Hash domain for these types anyway.
Followups (separate PRs, blocked on upstream):
Closes #1229