Skip to content

remove git dependency on hashes and hmac#923

Merged
tarcieri merged 1 commit intoRustCrypto:masterfrom
baloo:baloo/remove-git-dependencies
Mar 9, 2025
Merged

remove git dependency on hashes and hmac#923
tarcieri merged 1 commit intoRustCrypto:masterfrom
baloo:baloo/remove-git-dependencies

Conversation

@baloo
Copy link
Member

@baloo baloo commented Mar 9, 2025

No description provided.

@json420
Copy link
Contributor

json420 commented Mar 9, 2025

I don't know enough about the changes in hashes and hmac to saying anything too smart about this PR, but I do know that if I:

cargo add ml-dsa --git https://github.com/baloo/signatures.git --branch baloo/remove-git-dependencies
cargo add slh-dsa --git https://github.com/baloo/signatures.git --branch baloo/remove-git-dependencies
cargo build

Then that works! The same currently does not work from RustCrypto/signatures git master. So this is obvious forward progress for my two very most favorite signatures crates, ml-dsa and slh-dsa, haha 😛

For what it's worth, 👍 from me.

@tarcieri tarcieri merged commit 06b9cc9 into RustCrypto:master Mar 9, 2025
75 checks passed
@baloo baloo deleted the baloo/remove-git-dependencies branch March 9, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants