remove git dependency on hashes and hmac#923
Merged
tarcieri merged 1 commit intoRustCrypto:masterfrom Mar 9, 2025
Merged
Conversation
Contributor
|
I don't know enough about the changes in hashes and hmac to saying anything too smart about this PR, but I do know that if I: cargo add ml-dsa --git https://github.com/baloo/signatures.git --branch baloo/remove-git-dependencies
cargo add slh-dsa --git https://github.com/baloo/signatures.git --branch baloo/remove-git-dependencies
cargo buildThen that works! The same currently does not work from RustCrypto/signatures git master. So this is obvious forward progress for my two very most favorite signatures crates, For what it's worth, 👍 from me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.