ChaCha20 (legacy, xchacha): full 64bit counters#217
Merged
tarcieri merged 13 commits intoRustCrypto:masterfrom Jan 11, 2021
Merged
ChaCha20 (legacy, xchacha): full 64bit counters#217tarcieri merged 13 commits intoRustCrypto:masterfrom
tarcieri merged 13 commits intoRustCrypto:masterfrom
Conversation
Tests 1, 2, 3, 6, and 7 fail. I suspect they behave differently with the `avx2` backend since it depends on where the boundary of the buffer is. I don't think it's easy to exploit this unless you're trying really hard. That said, I believe it's possible for sufficiently determined user code to bypass the MAX_BLOCKS check and generate looped/overflowed keystream past 256GB.
Contributor
Author
|
I left the |
Bumps [rand_core](https://github.com/rust-random/rand) from 0.5.1 to 0.6.1. - [Release notes](https://github.com/rust-random/rand/releases) - [Changelog](https://github.com/rust-random/rand/blob/master/CHANGELOG.md) - [Commits](rust-random/rand@rand_core-0.5.1...rand_core-0.6.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
jpdoyle
force-pushed
the
64bit-counters
branch
from
c80434b to
2d2e3a8
Compare
Member
|
Thanks! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This:
Rounds-style tag trait for different possible values ofMAX_BLOCKScheck_data_lento an overflow-friendly version which can check 64-bit counters without requiring 128bit arithmeticChaCha20LegacyandXChaCha20.closes XChaCha20 unnecessarily limits keystream to 256gb #213