Conversation
Member
|
Apologies on the delayed review on this. I've glanced through it a few times and it seems mostly reasonable. I'd like to do a more detailed review before merging though, and it's been hard to justify prioritizing given the relatively meager performance gains. |
Member
|
Reviewed this again. It seems reasonable enough, and we're about to start making breaking changes anyway so I'd like to get it in before that. |
baloo
added a commit
to baloo/stream-ciphers
that referenced
this pull request
Mar 4, 2024
This reverts RustCrypto#328. The changes introduced here generate failure when used in `scrypt`. The `scrypt_block_mix` would generate a different value. I'm not able to figure out why that change breaks scrypt. Reverting until we can figure out why.
baloo
added a commit
to baloo/stream-ciphers
that referenced
this pull request
Mar 4, 2024
This reverts RustCrypto#328. The changes introduced here generate failure when used in `scrypt`. The `scrypt_block_mix` would generate a different value. I'm not able to figure out why that change breaks scrypt. Reverting until we can figure out why.
Merged
tarcieri
pushed a commit
that referenced
this pull request
Mar 5, 2024
This reverts #328. The changes introduced here generate failure when used in `scrypt`. The `scrypt_block_mix` would generate a different value. Note that this change was never released, so there is no security impact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #50
Hello, i had been trying to optimize salsa20 for sse2 since a while so i decided to publish a PR even if:
RustCryptoimplementations.With that said, feel free to discard the PR if you think it will not worth doing. Otherwise, i am totally open to suggestions and feedback to make this mergable to the project. Please review carefully if so, i might be missing important stuff. Thanks!
With the current salsa20 implementation i get this output from benches on my current computer:
While with this PR:
This numbers can vary from run to run a bit but the performance increase is consistent.