chacha20: unify quarter_round in soft backend and xchacha#349
chacha20: unify quarter_round in soft backend and xchacha#349tarcieri merged 2 commits intoRustCrypto:masterfrom
quarter_round in soft backend and xchacha#349Conversation
|
It seems it was duplicated because Perhaps it could be relocated somewhere it's always available. Failing other options, the toplevel |
|
Ok, i remember now the problem on using the soft backend version here and in xsalsa20. The soft backend is not compiled when we are in sse2 (or other) mode so is not available. In salsa20 we made this available because we are using soft when we are in any no salsa20/20 variant. https://github.com/RustCrypto/stream-ciphers/pull/348/files#diff-7b9d071b5f65d5c089bd999ab817ac1b72b33a365f1ec2e0ced9ef43d6495efeR1 I guess we can make it available for xchacha as well but i am unsure if compiling the extra code will be acceptable. |
Ok! |
|
Now I'm noticing we should really get #333 landed first |
|
@oxarbitrage need to re-evaluate this PR now that #333 has been merged |
15258ae to
072659e
Compare
072659e to
9ee394e
Compare
quarter_round in xchacha with soft backend versionquarter_round in soft backend and xchacha
|
Thanks! |
The
quarter_roundfunction is duplicated inside xchacha. We can just use the soft backend version, which is the same code.#348 (review)