chacha20 - adding the proper features for using legacy/djb construction#455
Merged
tarcieri merged 1 commit intoRustCrypto:masterfrom Sep 4, 2025
Merged
chacha20 - adding the proper features for using legacy/djb construction#455tarcieri merged 1 commit intoRustCrypto:masterfrom
chacha20 - adding the proper features for using legacy/djb construction#455tarcieri merged 1 commit intoRustCrypto:masterfrom
Conversation
Contributor
Author
|
We could alternatively have a module for the DJB construction so that way there's only one |
nstilt1
changed the title
chacha20 - adding the proper features for using legacy/djb construction
tarcieri
approved these changes
Sep 4, 2025
Contributor
Author
I change my mind about making a new module. I'm pretty sure we would need 2 cfg statements per variant instead of 1, which is almost as bad as 3 cfg statements, so it would not be that good to use more modules |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #454
If XChaCha is supposed to use the legacy/djb construction then we might need to add
xchachainto the mix.