password-hash: add Error::OutputSize#1026
Merged
tarcieri merged 2 commits intoRustCrypto:masterfrom Jan 9, 2023
Merged
Conversation
tarcieri
reviewed
Jun 16, 2022
password_hash::Error::OutputSizeError::OutputSize
cf55a17 to
c1f7018
Compare
Member
|
This is back to having three different variants that effectively mean different flavors of the same thing. What about this instead? OutputSize { expected: Ordering, size: usize } |
3387d43 to
c80afb1
Compare
Contributor
Author
I wasn't sure how you mean that, I kinda turned it around, the Also squashed the commits. EDIT: I hope the documentation is sufficient and alright. |
7808718 to
ea87046
Compare
tarcieri
reviewed
Jul 24, 2022
ea87046 to
a396237
Compare
tarcieri
approved these changes
Jul 24, 2022
Member
tarcieri
left a comment
There was a problem hiding this comment.
This looks good to me now.
It's a breaking change though, so I might keep this open until we're ready to start working on the next version of password-hash.
Contributor
Author
|
@tarcieri just saw the new update to 0.5.0-pre.0, are we ready to add this breaking change now? |
tarcieri
reviewed
Jan 9, 2023
Co-authored-by: Tony Arcieri <bascule@gmail.com>
70af450 to
91e2049
Compare
Member
|
Thanks! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See RustCrypto/password-hashes#313.
Sometimes a very specific output size is expected. Any bike-shedding is very welcome.