cipher: rename BlockCipher*/BlockMode*#1482
Merged
Conversation
Renames the following traits: - `BlockEncrypt` => `BlockCipherEncrypt` - `BlockDecrypt` => `BlockCipherDecrypt` - `BlockEncryptMut` => `BlockModeEncrypt` - `BlockDecryptMut` => `BlockModeDecrypt` As originally suggested in this comment: RustCrypto/block-modes#14 (comment) This better reflects how these traits are actually used, i.e. `BlockCipher*` is used by ciphers, and `BlockMode*` is used by their modes of operation.
tarcieri
changed the title
BlockCipher*/BlockMode*BlockCipher*/BlockMode*
newpavlov
approved these changes
Jan 21, 2024
Member
newpavlov
left a comment
newpavlov
left a comment
There was a problem hiding this comment.
Maybe it's worth to remove the _mut suffixes from BlockMode* method names? It may cause issues when both BlockMode* and BlockCipher* imported simultaneously, but I think it's a relatively rare situation in user code.
Member
Author
|
Hmm, guess I should've prepared a branch of https://github.com/rustcrypto/block-ciphers first because this is causing all sorts of wacky breakages including macro invocation failures like: |
tarcieri
commented
Jan 21, 2024
tarcieri
added a commit
that referenced
this pull request
Jan 22, 2024
The branch was never tested against the block ciphers repo located at https://github.com/rustcrypto/block-ciphers There were various errors and missed changes in macros which were required to get everything to compile. This includes fixes and has been tested against the downstream repo.
Member
Author
|
#1483 contains fixes to errors/omissions in this PR |
tarcieri
added a commit
that referenced
this pull request
Jan 22, 2024
The branch was never tested against the block ciphers repo located at https://github.com/rustcrypto/block-ciphers There were various errors and missed changes in macros which were required to get everything to compile. This includes fixes and has been tested against the downstream repo.
tarcieri
added a commit
to RustCrypto/block-ciphers
that referenced
this pull request
Jan 22, 2024
Updates the previous `BlockEncrypt`/`BlockEncrypt` trait names to use the new ones introduced in RustCrypto/traits#1482
tarcieri
added a commit
to RustCrypto/block-ciphers
that referenced
this pull request
Jan 22, 2024
Updates the previous `BlockEncrypt`/`BlockEncrypt` trait names to use the new ones introduced in RustCrypto/traits#1482
Merged
tarcieri
added a commit
that referenced
this pull request
Feb 4, 2026
### Added - Traits for tweakable block ciphers (#1721) - Methods for writing keystream (#1907) ### Changed - Replaced `generic-array` with `hybrid-array` (#1358) - Rename `BlockCipher*`/`BlockMode*` (#1482) - `BlockEncrypt` => `BlockCipherEncrypt` - `BlockDecrypt` => `BlockCipherDecrypt` - `BlockEncryptMut` => `BlockModeEncrypt` - `BlockDecryptMut` => `BlockModeDecrypt` - Split `BlockBackend` traits into 4 specific traits: (#1636) - `BlockCipherEncBackend` - `BlockCipherDecBackend` - `BlockModeEncBackend` - `BlockModeDecBackend` - Edition changed to 2024 and MSRV bumped to 1.85 (#1759) - Use `block_buffer::ReadBuffer` in `StreamCipherCoreWrapper` (#1959) - Re-export of `crypto-common` moved to `cipher::common` (#2237, #2260) - `crypto-common` dependency bumped to v0.2 (#2276) - `blobby` requirement bumped to v0.4 (#2147) - `inout` dependency bumped to v0.2.2 (#2149) ### Fixed - Bugs in `StreamCipherCoreWrapper` trait implementations (#1421) - Seeking implementation in the stream cipher wrapper (#2052) ### Removed - `std` feature (#1691) - `BlockCipherEncrypt::encrypt_padded*` and `BlockCipherDecrypt::decrypt_padded*` methods. Users of the ECB mode should use the `ecb-mode` crate instead. (#2245) - `AsyncStreamCipher` trait (#2280)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the following traits:
BlockEncrypt=>BlockCipherEncryptBlockDecrypt=>BlockCipherDecryptBlockEncryptMut=>BlockModeEncryptBlockDecryptMut=>BlockModeDecryptAs originally suggested in this comment:
RustCrypto/block-modes#14 (comment)
This better reflects how these traits are actually used, i.e.
BlockCipher*is used by ciphers, andBlockMode*is used by their modes of operation.