Skip to content

Remove signature error source from display message#1689

Merged
tarcieri merged 1 commit intoRustCrypto:masterfrom
casey:signature-error-display
Oct 8, 2024
Merged

Remove signature error source from display message#1689
tarcieri merged 1 commit intoRustCrypto:masterfrom
casey:signature-error-display

Conversation

@casey
Copy link
Copy Markdown
Contributor

@casey casey commented Oct 8, 2024

Since errors returned by std::error::Error::source() are commonly printed separately, this avoids double-printing the source error message.

Fixes #1685.

@tarcieri tarcieri merged commit 5acedcd into RustCrypto:master Oct 8, 2024
@casey casey deleted the signature-error-display branch October 8, 2024 01:36
@tarcieri tarcieri mentioned this pull request May 2, 2026
tarcieri added a commit that referenced this pull request May 2, 2026
## Added
- `RandomizedSignerMut` trait (#1448)
- `core::error::Error` support (#1711)
- Async traits incorporated from the `async-signature` crate (#1720, #2288)
- `MultipartSigner` and `MultipartVerifier` traits (#1880)

## Changed
- Edition changed to 2024 and MSRV bumped to 1.85 (#1759)
- Use `Fn(&mut D)` for `*DigestSigner`/`*DigestVerifier` (#2004)
- Bump `rand_core` to v0.10 (#2250)
- Bump `digest` to v0.11 (#2300)

## Removed
- Error source from display message (#1689)
- `std` feature (#1829)
- `derive` feature (#1843)
- `SignerMut` blanket implementation for `Signer` (#1915)
- `PrehashSignature` trait (#1924)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display implementation of signature::Error can lead to errors being printed twice

2 participants