Skip to content

signature: Remove blanket SignerMut impl (breaking change) #1915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tarcieri merged 2 commits into from
Jul 4, 2025
Merged

signature: Remove blanket SignerMut impl (breaking change) #1915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0822c1a
remove blanket `SignerMut` impl (breaking change)
carloskiki Jun 24, 2025
d02de5b
update CHANGELOG
carloskiki Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions signature/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Removed
- `std` feature - replaced with `core::error::Error`
- `derive` feature
- `SignerMut` blanket implementation for `Signer`

[#1448]: https://github.com/RustCrypto/traits/pull/1448
[#1759]: https://github.com/RustCrypto/traits/pull/1759
Expand Down
7 changes: 0 additions & 7 deletions signature/src/signer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,6 @@ pub trait SignerMut<S> {
fn try_sign(&mut self, msg: &[u8]) -> Result<S, Error>;
}

/// Blanket impl of [`SignerMut`] for all [`Signer`] types.
impl<S, T: Signer<S>> SignerMut<S> for T {
fn try_sign(&mut self, msg: &[u8]) -> Result<S, Error> {
T::try_sign(self, msg)
}
}

/// Sign the given prehashed message [`Digest`] using `Self`.
///
/// ## Notes
Expand Down