cipher: restore StreamCipherCoreWrapper::from_core#1983
Merged
Conversation
Removed in #1959 but there are definitely still quite a few usages and I don't see ways to completely replace all of them with `KeyIvInit` (though that seems ideal). See RustCrypto/AEADs#710
Member
Author
|
This seems sufficient to unblock RustCrypto/AEADs#710 which is now green in CI with a patch to use this branch so I'm going to go ahead and merge. @newpavlov I'm fine with removing |
tarcieri
deleted the
cipher/restore-streamciphercorewrapper-from-core
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed in #1959 but there are definitely still quite a few usages and I don't see ways to completely replace all of them with
KeyIvInit(though that seems ideal).See RustCrypto/AEADs#710