Closed
Conversation
Though I think the `Generate` trait covers a lot of use cases, for anyone who wants to use `SysRng` with `CryptoRng` this is a little more convenient than importing both `SysRng` and `Unwrap` and assembling it yourself.
Member
|
I don't think we should implement it ourselves. I tried to add it to Also note that creating value of the aliased type would be less convenient than with |
Member
Author
|
Oh hey look at that you proposed the same thing. Yeah, the main thing that's nice is it cuts the two imports down to one. |
Member
Author
|
I'll close this for now and if it gets upstream it gets upstream, I guess |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Though I think the
Generatetrait covers a lot of use cases, for anyone who wants to useSysRngwithCryptoRngthis is a little more convenient than importing bothSysRngandUnwrapand assembling it yourself.