cipher: re-export generic_array from toplevel#343
Merged
Conversation
...along with `typenum::consts` Failure to do this was an oversight: it doesn't really make sense to re-export these twice from both the `block` and `stream` modules. That said, `cipher` v0.2 is already shipped, and it does ease a sed-based migration to keep these re-exports for now. This commit adds a third re-export from the toplevel, and comments to remove the re-exports from the `block` and `stream` crates. This should happen before `cipher` v0.3 is released.
tarcieri
force-pushed
the
cipher/toplevel-generic-array-reexport
branch
from
6958a2b to
f6f9581
Compare
This was referenced Oct 16, 2020
Merged
dns2utf8
pushed a commit
to dns2utf8/traits
that referenced
this pull request
Jan 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...along with
typenum::constsFailure to do this was an oversight: it doesn't really make sense to re-export these twice from both the
blockandstreammodules.That said,
cipherv0.2 is already shipped, and it does ease a sed-based migration to keep these re-exports for now.This commit adds a third re-export from the toplevel, and comments to remove the re-exports from the
blockandstreamcrates. This should happen beforecipherv0.3 is released.