[WIP] exploring a BlockCipher marker trait (not for merge)#353
Closed
[WIP] exploring a BlockCipher marker trait (not for merge)#353
BlockCipher marker trait (not for merge)#353Conversation
Closes #349 Adds `Encrypt` and `Decrypt` traits which can be used in cases where e.g. only the encryption portion of a block cipher is used, as in CTR mode. This PR does not otherwise attempt to add things like a blanket impl.
Attempt at refactoring `BlockCipher` into a trait which marks a type as being capable of both `Encrypt` and `Decrypt`. As far as I can tell this requires the unfortunate change of making the block size and parallel block parameters generic.
Member
Author
|
Closing this in favor of @newpavlov's suggestion from #352. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt at refactoring
BlockCipherinto a trait which marks a type as being capable of bothEncryptandDecrypt.As far as I can tell this requires the unfortunate change of making the block size and parallel block parameters generic.