Conversation
This implements the changes proposed in #681 to simplify access to the `rand_core` traits and `OsRng`. `rand_core` is conditionally re-exported when the eponymous crate feature is enabled. Additionally, the `std` crate feature enables `rand_core/std`, which permits access to `OsRng` as `aead::rand_core::OsRng`.
tarcieri
force-pushed
the
aead/re-export-rand_core
branch
from
65819a3 to
55de140
Compare
newpavlov
approved these changes
Jul 10, 2021
Member
newpavlov
left a comment
newpavlov
left a comment
There was a problem hiding this comment.
Looks good! Although I am not sure about enabling it by default. Right now in most implementation crates we use default-features = false on the aead dependency, so it will have no effect. It could be better to enable it by default in implementation crates and then forward it to aead. It will be similar to how we handle std for example in the has crates.
Member
Author
|
Removed the default feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the changes proposed in #681 to simplify access to the
rand_coretraits andOsRng.rand_coreis conditionally re-exported when the eponymous crate feature is enabled.Additionally, the
stdcrate feature enablesrand_core/std, which permits access toOsRngasaead::rand_core::OsRng.