Conversation
tarcieri
left a comment
There was a problem hiding this comment.
Also I do not forward std to rand_core in this case since doing it correctly requires weak feature activation.
The nice thing about doing this is it makes it possible to access OsRng without an additional crate dependency.
Perhaps as an alternative, we can add a getrandom feature which enables rand_core/getrandom instead?
|
We still will pull BTW such complications is one of the reasons why I am not a huge fan of preview features and generally err on the side of caution with 1.0 releases. |
|
I'll leave it up to you how you want to handle |
|
I think I will leave it as is then. Mostly because |
Closes #681
Also issue compilation errors if unstable functionality in the
signaturecrate is enabled by toggling features introduced by optional dependencies. In theory it may break build for some people, but it would've happened eventually either way. Also I do not forwardstdtorand_corein this case since doing it correctly requires weak feature activation.