Skip to content

Defined the SignerMut trait#734

Merged
tarcieri merged 4 commits intoRustCrypto:masterfrom
rozbb:stateful-signer
Sep 5, 2021
Merged

Defined the SignerMut trait#734
tarcieri merged 4 commits intoRustCrypto:masterfrom
rozbb:stateful-signer

Conversation

@rozbb
Copy link
Copy Markdown
Contributor

@rozbb rozbb commented Sep 4, 2021

As per our discussion on the RCIG Zulip, there seems to be a need for a stateful version of the Signer trait. This lets us support "Key Evolving Signature Schemes" such as XMSS.

One thing that is unclear so far is whether we also want to do stateful versions of DigestSigner, RandomizedSigner, and AsyncSigner. I think the latter two won't be an issue for now, since XMSS is a deterministic scheme, and HSMs do not support XMSS.

@tarcieri
Copy link
Copy Markdown
Member

tarcieri commented Sep 4, 2021

@rozbb rozbb changed the title Defined the StatefulSigner trait Defined the SignerMut trait Sep 5, 2021
@rozbb
Copy link
Copy Markdown
Contributor Author

rozbb commented Sep 5, 2021

Fixed

Copy link
Copy Markdown
Member

@tarcieri tarcieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me.

Our other *Mut traits also have blanket impls of the stateful *Mut trait for types which impl the stateless trait, which might also make sense here.

@tarcieri tarcieri merged commit 09d9ea6 into RustCrypto:master Sep 5, 2021
@tarcieri
Copy link
Copy Markdown
Member

tarcieri commented Sep 5, 2021

Thank you!

@rozbb
Copy link
Copy Markdown
Contributor Author

rozbb commented Sep 5, 2021

Sorry one more thing: I just pushed another commit to this branch. It wasn't 100% clear to me that my blanket impl wasn't trivially gonna loop forever. Feel free to copy into the tree

@tarcieri
Copy link
Copy Markdown
Member

tarcieri commented Sep 5, 2021

Oh huh, can you make sure one way or another and open another PR if it's broken?

@rozbb
Copy link
Copy Markdown
Contributor Author

rozbb commented Sep 5, 2021 via email

@rozbb
Copy link
Copy Markdown
Contributor Author

rozbb commented Sep 6, 2021 via email

This was referenced Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants