Skip to content

hybrid-array: Impl Zeroize for Array#984

Merged
tarcieri merged 5 commits intoRustCrypto:masterfrom
rozbb:hybrid-array-zeroize
Nov 19, 2023
Merged

hybrid-array: Impl Zeroize for Array#984
tarcieri merged 5 commits intoRustCrypto:masterfrom
rozbb:hybrid-array-zeroize

Conversation

@rozbb
Copy link
Contributor

@rozbb rozbb commented Nov 18, 2023

Let me know if you wanna feature gate this.

@rozbb
Copy link
Contributor Author

rozbb commented Nov 18, 2023

I think it might not be possible to make Drop zeroize everything. If you try impl<T: Zeroize, U: ArraySize> Drop for Array<T, U>, it complains that you cannot specialize Drop impls.

@rozbb
Copy link
Contributor Author

rozbb commented Nov 18, 2023

Alright should be good to go

@rozbb
Copy link
Contributor Author

rozbb commented Nov 19, 2023

I believe build is failing because of outdated MSRV elsewhere

tarcieri added a commit that referenced this pull request Nov 19, 2023
This is a simple command line utility intended for internal use only.

There's no need to have an MSRV policy around it, and having one was
breaking the build of #984
tarcieri added a commit that referenced this pull request Nov 19, 2023
This is a simple command line utility intended for internal use only.

There's no need to have an MSRV policy around it, and having one was
breaking the build of #984
tarcieri added a commit that referenced this pull request Nov 19, 2023
This is a simple command line utility intended for internal use only.

There's no need to have an MSRV policy around it, and having one was
breaking the build of #984
@tarcieri
Copy link
Member

#986 removed the MSRV from fiat-constify if you rebase

Co-authored-by: Tony Arcieri <bascule@gmail.com>
@tarcieri tarcieri merged commit 3ed8852 into RustCrypto:master Nov 19, 2023
@rozbb rozbb deleted the hybrid-array-zeroize branch November 19, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants