feat(docs): align docs styling with main site glassmorphic theme#157
feat(docs): align docs styling with main site glassmorphic theme#157anirudhxmishra wants to merge 2 commits into
Conversation
📝 WalkthroughWalkthroughUpdates the docs site: rewrites README, restructures Docusaurus config, adds a glassmorphic design system in CSS, and wraps homepage content with Changes
Sequence Diagram(s)(omitted — changes are configuration and styling only) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related issues
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (1)
docs/docusaurus.config.js (1)
138-145: Remove unnecessarytoproperty ondocSidebarnavbar item.The
docSidebarnavbar item type automatically links to the first document of the specified sidebar, making theto: '/docs'property redundant. Simplify by removing it.{ type: 'docSidebar', sidebarId: 'tutorialSidebar', position: 'left', label: 'Documentation', - to: '/docs', },
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
docs/static/img/og-icon.pngis excluded by!**/*.png
📒 Files selected for processing (4)
docs/README.mddocs/docusaurus.config.jsdocs/src/css/custom.cssdocs/src/pages/index.md
🧰 Additional context used
🧠 Learnings (3)
📚 Learning: 2025-12-20T20:11:28.389Z
Learnt from: Ryan-Millard
Repo: Ryan-Millard/Img2Num PR: 0
File: :0-0
Timestamp: 2025-12-20T20:11:28.389Z
Learning: In the Img2Num repository, all documentation should be properly organized in the docs/docs/ folder structure following the Docusaurus conventions, either as a dedicated category or integrated into existing categories like project-scripts.
Applied to files:
docs/README.md
📚 Learning: 2025-12-17T22:39:25.704Z
Learnt from: Ryan-Millard
Repo: Ryan-Millard/Img2Num PR: 0
File: :0-0
Timestamp: 2025-12-17T22:39:25.704Z
Learning: In the Img2Num repository, do not create multiple markdown files at the repository root. The README.md at root should remain brief and point to the Docusaurus site.
Applied to files:
docs/README.mddocs/docusaurus.config.js
📚 Learning: 2025-12-17T22:39:25.704Z
Learnt from: Ryan-Millard
Repo: Ryan-Millard/Img2Num PR: 0
File: :0-0
Timestamp: 2025-12-17T22:39:25.704Z
Learning: In the Img2Num repository, all documentation must be placed in the docs/docs/ folder following the Docusaurus structure, not at the repository root.
Applied to files:
docs/README.md
🔇 Additional comments (6)
docs/src/pages/index.md (1)
9-10: Glass-card wrapper looks good.The wrapper div with
className="glass-card"correctly applies the new glassmorphic styling defined incustom.css. The structure is clean and properly opened/closed.Also applies to: 37-38
docs/src/css/custom.css (1)
50-77: Well-structured glassmorphic component with progressive enhancement.Good approach using
@supportsqueries to progressively enhance withbackdrop-filterwhile providing solid fallback backgrounds. The-webkit-backdrop-filterprefix ensures Safari compatibility. Dark mode is properly handled for the base.glass-cardclass.docs/README.md (1)
23-28: Good addition of styling notes.The new styling notes section clearly documents where key files live, making it easier for contributors to understand the codebase structure. This aligns well with the repository's documentation practices.
docs/docusaurus.config.js (3)
14-26: Good defensive handling for Algolia configuration.The conditional check for all three Algolia environment variables before creating the config object is a clean pattern. This prevents runtime errors when the search credentials aren't available (e.g., in local development or CI without secrets).
40-42: Note:future.v4: trueenables Docusaurus v4 compatibility mode.This flag opts into upcoming v4 breaking changes early, which is good for forward compatibility. Ensure the team is aware this may introduce subtle behavioral changes as Docusaurus prepares for v4.
121-130: Algolia config is optional in Docusaurus v3.9.2 and handles undefined gracefully.When algolia env vars are missing, passing
algolia: undefinedis safe. The algolia field in themeConfig is optional, and Docusaurus has already fixed historical issues where undefined algolia would break the searchbar. The theme simply omits search functionality when algolia is not configured, without generating warnings or errors.
|
Thanks! All suggested fixes have been applied in the latest commit. |
e2d48f2 to
de448c2
Compare
|
Thanks! I’ve resolved the rebase conflict in |
|
Thanks! All requested changes are addressed. |
Ryan-Millard
left a comment
There was a problem hiding this comment.
Hi. Please will you style the entire site in the same way that the main app has been styled.
There is a dark mode coming soon (see #121 for reference), so it may be worthwhile to copy the current light mode styles from there, then wait for it to be merged before using the dark mode styles (since they may change after the review I just left on it).
What I'd like from this PR:
- All images updated - social, logo, etc. (Docusaurus included defaults that have not yet been updated to Img2Num's)
- Background updated to match the setup in #121 (background image with transparent background and a dynamic background that updates when the user clicks on the theme switch button)
- Glassmorphic styles from the main app being ported over into the Docusaurus app so we can maintain consistency. For example, the table below on the Introduction to FFTs page needs to look like the table example below it from the Credits page:
|
Hi @anirudhxmishra! I'm just checking in to see if you're still interested in this pull request. Do you need any help or would you like someone else to take over from you in this PR? |
|
@Ryan-Millard I ll work on it been busy due to some work. |
Thanks for the update! #157 requires the Docusaurus app to be styled in the same way as the main React app is - that means reusing the global CSS code and glassmorphic styles. For example, the background needs to be changed to the pink color that the main app uses in light mode and the plum/purple color that it uses in dark mode. |
|
@Ryan-Millard, due to unforeseen work commitments, I am unable to proceed. Would it be possible to have someone else take over? |
@anirudhxmishra, thank you for the update. Please will you comment I'm going to close this pull request since it is incomplete and won't be fixing #150. |
|
/untake on #150 |
Fixes #150
Summary
This PR aligns the Docusaurus docs site styling with the main Img2Num site by introducing a centralized glassmorphic design system and consistent branding.
Changes
docs/src/css/custom.css.glass-cardcomponent with accessible fallbacksChecklist
docs/static/imgSummary by CodeRabbit
New Features
Documentation
Bug Fixes
Style
✏️ Tip: You can customize this high-level summary in your review settings.