chore(deps-js): update all pnpm dependencies#327
Conversation
- React-Helmet changed to React-Helmet-Async - Lucide API broke, so SVGR was added to allow us to keep example app's GitHub icon in the Navbar
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (51)
📝 WalkthroughWalkthroughUpgrades React app dependencies, migrates from react-helmet to react-helmet-async (provider + imports), replaces Lucide Github icon with an SVG component, adds vite-plugin-svgr, applies formatting/refactoring across C/C++/bindings, and updates tooling/configs and documentation import quoting and prettier settings. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 25 minutes and 4 seconds.Comment |
There was a problem hiding this comment.
Actionable comments posted: 7
🧹 Nitpick comments (1)
example-apps/react-js/src/components/NavBar.jsx (1)
2-2: Nit: stray double space in import.Minor formatting: there's a double space between
Info,andSquareArrowOutUpRight.-import { Home, Users, Info, SquareArrowOutUpRight, Menu, X } from "lucide-react"; +import { Home, Users, Info, SquareArrowOutUpRight, Menu, X } from "lucide-react";🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@example-apps/react-js/src/components/NavBar.jsx` at line 2, Remove the stray double space in the import list in NavBar.jsx so the import statement is consistently formatted; specifically, fix the spacing between the Info and SquareArrowOutUpRight symbols in the import of Home, Users, Info, SquareArrowOutUpRight, Menu, X from "lucide-react" (update the import containing the Home/Users/Info/SquareArrowOutUpRight/Menu/X identifiers).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/package.json`:
- Line 119: The dotenv upgrade changed default logging; locate the dotenv
.config() call in docs/docusaurus.config.js (the import and the .config()
invocation) and update the invocation to pass the quiet option (i.e., call
.config({ quiet: true })) so dotenv won’t print "injected env" messages to
stdout during builds.
- Line 132: The `@docusaurus/faster` package was added but not enabled in the
Docusaurus config; update docusaurus.config.js to set future.faster to true (in
addition to the existing future: { v4: true }) so the faster build pipeline is
activated, or remove the "@docusaurus/faster" dependency from package.json if
you don't intend to use it; edit the future block in docusaurus.config.js (where
future: { v4: true } is defined) to include faster: true.
In `@example-apps/react-js/src/App.jsx`:
- Line 3: Remove the unused import of HelmetProvider from App.jsx: the symbol
HelmetProvider is declared in the import list but never used inside the App
component, so delete that import line and run lint to confirm no other
references to HelmetProvider remain; ensure the actual provider wiring that
wraps the app (where HelmetProvider is intentionally used) is left unchanged.
In `@example-apps/react-js/src/components/NavBar.jsx`:
- Line 8: The imported GitHub SVG hardcodes width/height and won't respect the
lucide-style size prop used when rendering via React.createElement(icon, { size
}), so remove the fixed width/height attributes from src/assets/GitHub.svg and
replace the direct import with a small wrapper component (e.g., GitHubIcon) that
accepts a size prop and forwards it as width/height to the SVG (matching lucide
API), then update usages in INTERNAL_LINKS/EXTERNAL_LINKS (the places calling
React.createElement(icon, { size: ... })) to import the wrapper instead of the
raw SVGR component; alternatively implement an SVGR template that maps size →
width/height globally if you prefer.
In `@example-apps/react-js/src/main.jsx`:
- Line 6: Remove the unused HelmetProvider import from App.jsx: locate the
import statement that imports HelmetProvider from "react-helmet-async" in the
App.jsx module and delete it (or replace with only needed imports); confirm
there are no references to HelmetProvider inside the App component and run the
linter to ensure the warning is gone to avoid accidental double-wrapping at the
root where HelmetProvider is already applied.
In `@packages/js/package.json`:
- Around line 38-40: Remove the runtime dependency addition of
"react-helmet-async" from package.json: delete the "react-helmet-async" entry
under the "dependencies" object so the published img2num package does not force
React peer installs; since the package's files (index.js, safeWasmWrappers.js,
wasmClient.js, wasmWorker.js, imageToUint8ClampedArray.js) do not use
Helmet/React, ensure no other code references "react-helmet-async" (search for
that string) and leave any dev/test-only tooling as devDependencies instead of
runtime dependencies.
In `@scripts/img2num-dev-scripts/package.json`:
- Line 8: Remove the unused "react-helmet-async" dependency from the
img2num-dev-scripts package.json (delete the "react-helmet-async": "^3.0.0"
entry) so the CLI package no longer declares an unnecessary React peer
dependency; ensure you update either "dependencies" or "devDependencies" where
that entry lives and run a reinstall to verify no peer-dep warnings remain.
---
Nitpick comments:
In `@example-apps/react-js/src/components/NavBar.jsx`:
- Line 2: Remove the stray double space in the import list in NavBar.jsx so the
import statement is consistently formatted; specifically, fix the spacing
between the Info and SquareArrowOutUpRight symbols in the import of Home, Users,
Info, SquareArrowOutUpRight, Menu, X from "lucide-react" (update the import
containing the Home/Users/Info/SquareArrowOutUpRight/Menu/X identifiers).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: e9d97dca-48b6-4e83-a11b-89747531d204
⛔ Files ignored due to path filters (2)
example-apps/react-js/src/assets/GitHub.svgis excluded by!**/*.svgpnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (13)
docs/package.jsonexample-apps/react-js/package.jsonexample-apps/react-js/src/App.jsxexample-apps/react-js/src/components/NavBar.jsxexample-apps/react-js/src/main.jsxexample-apps/react-js/src/pages/About/AboutHelmet.jsxexample-apps/react-js/src/pages/Credits/CreditsHelmet.jsxexample-apps/react-js/src/pages/Editor/EditorHelmet.jsxexample-apps/react-js/src/pages/Home/HomeHelmet.jsxexample-apps/react-js/vite.config.jspackage.jsonpackages/js/package.jsonscripts/img2num-dev-scripts/package.json
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
scripts/format-cpp.js (1)
16-16: Minor: renameRECURSE_C_OR_CPP_FILESto reflect that it's a glob pattern.The constant holds a glob, not a recursion behavior. Something like
C_CPP_FILES_GLOBorCPP_GLOB_SUFFIXreads more accurately at the call sites (core/${...}).🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@scripts/format-cpp.js` at line 16, The constant RECURSE_C_OR_CPP_FILES is misnamed because it holds a glob pattern; rename it to a clearer identifier like C_CPP_FILES_GLOB (or CPP_GLOB_SUFFIX) everywhere in scripts/format-cpp.js and any importers/call sites so usage reads accurately (e.g., core/${C_CPP_FILES_GLOB}) — update the declaration and all references to the new symbol name to keep behavior unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/docs/c/index.md`:
- Line 7: The JSX comment {/* DO NOT CHANGE THE TITLE (see
`@site/src/md/_partials/IntsallingCoreOrCFromSrc.md` and the C++ version of this
page to understand why */} triggers MD037 due to spaces inside the
brace-delimited comment; replace it with the same comment text but without
surrounding spaces inside the braces (i.e., use the exact comment body "DO NOT
CHANGE THE TITLE (see `@site/src/md/_partials/IntsallingCoreOrCFromSrc.md` and the
C++ version of this page to understand why)" wrapped immediately by {/*...*/})
so the comment matches MD style and removes the lint warning.
In `@docs/docs/contributing/setup-and-dependencies/index.md`:
- Around line 125-127: The TabItem blocks for values "root", "docs", and
"react-example" contain malformed inline code spans and should be converted into
proper fenced code blocks: replace the inline backtick usage inside each
<TabItem value="root">, <TabItem value="docs">, and <TabItem
value="react-example"> with a triple-backtick fenced block using the bash title
metadata (e.g. ```bash title="Fuzzy find scripts local to the root project") and
include the full command line starting with ./img2num (preserve the Docker-first
./img2num prefix) on the following line, then close with ``` before </TabItem>;
ensure no extra spaces or pseudo-fence text remain so the command renders as a
code block and removes MD038 warnings.
In `@docs/docs/cpp/index.md`:
- Line 7: The JSX block comment on the line containing {/* DO NOT CHANGE THE
TITLE (see `@site/src/md/_partials/IntsallingCoreOrCFromSrc.md` and the C version
of this page to understand why */} triggers markdownlint MD037 due to spaces
inside the comment tokens; remove the extra spaces so the comment uses tight
tokens (e.g. {/*DO NOT CHANGE THE TITLE (see
`@site/src/md/_partials/IntsallingCoreOrCFromSrc.md` and the C version of this
page to understand why*/}) to satisfy MD037 while preserving the exact text and
intent of the comment.
---
Nitpick comments:
In `@scripts/format-cpp.js`:
- Line 16: The constant RECURSE_C_OR_CPP_FILES is misnamed because it holds a
glob pattern; rename it to a clearer identifier like C_CPP_FILES_GLOB (or
CPP_GLOB_SUFFIX) everywhere in scripts/format-cpp.js and any importers/call
sites so usage reads accurately (e.g., core/${C_CPP_FILES_GLOB}) — update the
declaration and all references to the new symbol name to keep behavior
unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5e9d608c-f086-47c8-b8de-ee9e1ed72593
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (41)
.prettierignore.prettierrcbindings/py/src/img2num_pybind.cppdocs/blog/2025-12-05-launch.mddocs/docs/c/api-reference.mddocs/docs/c/docs/index.mddocs/docs/c/index.mddocs/docs/contributing/setup-and-dependencies/index.mddocs/docs/cpp/api-reference.mddocs/docs/cpp/docs/index.mddocs/docs/cpp/index.mddocs/docs/internal/example-apps/console-c-and-console-cpp/index.mddocs/docs/internal/example-apps/react-js/css/global/variables/theme/dark.mddocs/docs/internal/example-apps/react-js/css/global/variables/theme/light.mddocs/docs/internal/packages/js/index.mddocs/docs/js/docs/index.mddocs/docs/js/index.mddocs/docusaurus.config.jsdocs/package.jsondocs/src/md/_partials/IntsallingCoreOrCFromSrc.mddocs/src/pages/credits.mddocs/src/pages/index.mddocs/versioned_docs/version-old/introduction/getting-started.mddocs/versioned_docs/version-old/reference/react/css/global/variables/theme/dark.mddocs/versioned_docs/version-old/reference/react/css/global/variables/theme/light.mddocs/versioned_docs/version-old/reference/react/workers/wasmWorker.mddocs/versioned_docs/version-old/reference/wasm/modules/image/bilateral_filter/color-spaces.mddocs/versioned_docs/version-old/reference/wasm/modules/image/bilateral_filter/implementation.mddocs/versioned_docs/version-old/reference/wasm/modules/image/fft_iterative/prerequisite-theory/continuous-fourier-transform/index.mddocs/versioned_docs/version-old/reference/wasm/modules/image/fft_iterative/prerequisite-theory/fourier-series--the-bridge/index.mddocs/versioned_docs/version-old/reference/wasm/modules/image/fft_iterative/prerequisite-theory/how-fourier-transforms-work/index.mddocs/versioned_docs/version-old/reference/wasm/modules/image/fft_iterative/prerequisite-theory/introduction/index.mddocs/versioned_docs/version-old/reference/wasm/modules/image/fft_iterative/prerequisite-theory/keywords.mddocs/versioned_docs/version-old/reference/wasm/modules/image/graph/explained.mddocs/versioned_docs/version-old/reference/wasm/setup-and-dependencies.mdexample-apps/console-c/main.cexample-apps/console-cpp/main.cppexample-apps/react-js/src/components/NavBar.jsxexample-apps/react-js/vite.config.jspackages/js/package.jsonscripts/format-cpp.js
✅ Files skipped from review due to trivial changes (31)
- docs/blog/2025-12-05-launch.md
- docs/src/pages/index.md
- docs/docs/cpp/docs/index.md
- docs/docs/c/docs/index.md
- .prettierrc
- docs/docs/internal/example-apps/react-js/css/global/variables/theme/light.md
- docs/docs/internal/example-apps/react-js/css/global/variables/theme/dark.md
- docs/versioned_docs/version-old/reference/wasm/modules/image/bilateral_filter/implementation.md
- docs/docusaurus.config.js
- docs/versioned_docs/version-old/reference/wasm/modules/image/fft_iterative/prerequisite-theory/keywords.md
- docs/versioned_docs/version-old/reference/wasm/modules/image/bilateral_filter/color-spaces.md
- docs/versioned_docs/version-old/reference/react/css/global/variables/theme/dark.md
- docs/docs/internal/example-apps/console-c-and-console-cpp/index.md
- docs/versioned_docs/version-old/reference/react/workers/wasmWorker.md
- docs/docs/internal/packages/js/index.md
- docs/versioned_docs/version-old/reference/react/css/global/variables/theme/light.md
- docs/docs/js/docs/index.md
- docs/versioned_docs/version-old/reference/wasm/modules/image/fft_iterative/prerequisite-theory/how-fourier-transforms-work/index.md
- packages/js/package.json
- docs/src/pages/credits.md
- docs/versioned_docs/version-old/introduction/getting-started.md
- docs/docs/cpp/api-reference.md
- docs/versioned_docs/version-old/reference/wasm/modules/image/graph/explained.md
- .prettierignore
- docs/versioned_docs/version-old/reference/wasm/modules/image/fft_iterative/prerequisite-theory/introduction/index.md
- docs/docs/js/index.md
- docs/docs/c/api-reference.md
- example-apps/console-c/main.c
- docs/versioned_docs/version-old/reference/wasm/setup-and-dependencies.md
- example-apps/console-cpp/main.cpp
- bindings/py/src/img2num_pybind.cpp
🚧 Files skipped from review as they are similar to previous changes (3)
- example-apps/react-js/vite.config.js
- example-apps/react-js/src/components/NavBar.jsx
- docs/package.json
…ax so abrasively?
There was a problem hiding this comment.
♻️ Duplicate comments (1)
docs/docs/contributing/setup-and-dependencies/index.md (1)
127-129:⚠️ Potential issue | 🟡 MinorFix malformed command formatting in
TabItemblocks (Lines 127-129).The commands are currently inline code spans with pseudo-fence text, which breaks intended rendering and triggers MD038. Use proper fenced code blocks inside each
TabItem.Proposed fix
- <TabItem value="root">`bash title="Fuzzy find scripts local to the root project" ./img2num pnpm run help `</TabItem> - <TabItem value="docs">`bash title="Fuzzy find scripts local to the documentation" ./img2num pnpm run -F docs help `</TabItem> - <TabItem value="react-example">`bash title="Fuzzy find scripts local to the React Example app" ./img2num pnpm run -F react-example help `</TabItem> + <TabItem value="root"> + ```bash title="Fuzzy find scripts local to the root project" + ./img2num pnpm run help + ``` + </TabItem> + <TabItem value="docs"> + ```bash title="Fuzzy find scripts local to the documentation" + ./img2num pnpm run -F docs help + ``` + </TabItem> + <TabItem value="react-example"> + ```bash title="Fuzzy find scripts local to the React Example app" + ./img2num pnpm run -F react-example help + ``` + </TabItem>Based on learnings, Docker-first commands via
./img2num ...should be preserved in docs guidance.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/docs/contributing/setup-and-dependencies/index.md` around lines 127 - 129, The three <TabItem> blocks (values "root", "docs", "react-example") contain malformed inline code spans instead of proper fenced code blocks; replace each inline backtick string with a fenced code block using triple backticks (```bash title="...") inside the corresponding <TabItem>, preserving the Docker-first commands (e.g. ./img2num pnpm run help and ./img2num pnpm run -F docs help, ./img2num pnpm run -F react-example help) and close each block with ``` before the </TabItem> to fix rendering and satisfy MD038.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@docs/docs/contributing/setup-and-dependencies/index.md`:
- Around line 127-129: The three <TabItem> blocks (values "root", "docs",
"react-example") contain malformed inline code spans instead of proper fenced
code blocks; replace each inline backtick string with a fenced code block using
triple backticks (```bash title="...") inside the corresponding <TabItem>,
preserving the Docker-first commands (e.g. ./img2num pnpm run help and ./img2num
pnpm run -F docs help, ./img2num pnpm run -F react-example help) and close each
block with ``` before the </TabItem> to fix rendering and satisfy MD038.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 86b157f4-f488-4418-87b4-0851bb92b80c
📒 Files selected for processing (27)
docs/docs/c/docs/index.mddocs/docs/c/index.mddocs/docs/contributing/setup-and-dependencies/index.mddocs/docs/cpp/docs/index.mddocs/docs/cpp/index.mddocs/docs/internal/example-apps/console-c-and-console-cpp/index.mddocs/docs/internal/example-apps/react-js/css/global/variables/theme/dark.mddocs/docs/internal/example-apps/react-js/css/global/variables/theme/light.mddocs/docs/internal/packages/js/index.mddocs/docs/js/docs/index.mddocs/docs/js/index.mddocs/src/md/_partials/IntsallingCoreOrCFromSrc.mddocs/src/pages/credits.mddocs/src/pages/index.mddocs/versioned_docs/version-old/introduction/getting-started.mddocs/versioned_docs/version-old/reference/react/css/global/variables/theme/dark.mddocs/versioned_docs/version-old/reference/react/css/global/variables/theme/light.mddocs/versioned_docs/version-old/reference/react/workers/wasmWorker.mddocs/versioned_docs/version-old/reference/wasm/modules/image/bilateral_filter/color-spaces.mddocs/versioned_docs/version-old/reference/wasm/modules/image/bilateral_filter/implementation.mddocs/versioned_docs/version-old/reference/wasm/modules/image/fft_iterative/prerequisite-theory/continuous-fourier-transform/index.mddocs/versioned_docs/version-old/reference/wasm/modules/image/fft_iterative/prerequisite-theory/fourier-series--the-bridge/index.mddocs/versioned_docs/version-old/reference/wasm/modules/image/fft_iterative/prerequisite-theory/how-fourier-transforms-work/index.mddocs/versioned_docs/version-old/reference/wasm/modules/image/fft_iterative/prerequisite-theory/introduction/index.mddocs/versioned_docs/version-old/reference/wasm/modules/image/fft_iterative/prerequisite-theory/keywords.mddocs/versioned_docs/version-old/reference/wasm/modules/image/graph/explained.mddocs/versioned_docs/version-old/reference/wasm/setup-and-dependencies.md
✅ Files skipped from review due to trivial changes (24)
- docs/docs/internal/example-apps/react-js/css/global/variables/theme/dark.md
- docs/versioned_docs/version-old/reference/react/css/global/variables/theme/light.md
- docs/docs/c/docs/index.md
- docs/versioned_docs/version-old/reference/wasm/modules/image/fft_iterative/prerequisite-theory/keywords.md
- docs/docs/cpp/docs/index.md
- docs/src/pages/credits.md
- docs/versioned_docs/version-old/reference/react/css/global/variables/theme/dark.md
- docs/versioned_docs/version-old/reference/wasm/modules/image/bilateral_filter/color-spaces.md
- docs/src/pages/index.md
- docs/versioned_docs/version-old/reference/wasm/modules/image/fft_iterative/prerequisite-theory/how-fourier-transforms-work/index.md
- docs/docs/c/index.md
- docs/docs/internal/packages/js/index.md
- docs/versioned_docs/version-old/reference/wasm/modules/image/bilateral_filter/implementation.md
- docs/versioned_docs/version-old/reference/wasm/modules/image/fft_iterative/prerequisite-theory/fourier-series--the-bridge/index.md
- docs/docs/js/docs/index.md
- docs/docs/cpp/index.md
- docs/versioned_docs/version-old/reference/react/workers/wasmWorker.md
- docs/docs/js/index.md
- docs/versioned_docs/version-old/reference/wasm/modules/image/fft_iterative/prerequisite-theory/introduction/index.md
- docs/docs/internal/example-apps/react-js/css/global/variables/theme/light.md
- docs/docs/internal/example-apps/console-c-and-console-cpp/index.md
- docs/versioned_docs/version-old/reference/wasm/setup-and-dependencies.md
- docs/versioned_docs/version-old/introduction/getting-started.md
- docs/versioned_docs/version-old/reference/wasm/modules/image/graph/explained.md
Importantly, Markdown-style comments had to be changed to match the latest upgrades to Docusaurus. We now use React-style comments for the MDX code.
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
|
@coderabbitai, suggest a conventional commit message and description for this PR. I will be squashing it. |
|
Tip For best results, initiate chat on the files or code changes.
Subject line: Body: 🧠 Learnings used |
What was changed & why
JS dependencies updated to fix vulnerabilities and hush irrelevant warnings.
Fixes: #none
Changes
React-Helmet-AsyncfromReact-Helmet-> it is the new standardTesting & Verification
Additional Resources
Summary by CodeRabbit
New Features
Chores