Conversation
Ryotaro25
commented
Aug 19, 2024
Owner
Author
There was a problem hiding this comment.
gitignoreの設定誤って履歴消せなくなりました。
oda
reviewed
Aug 19, 2024
| if (!root) { | ||
| return false; | ||
| } | ||
| if (!root->left && !root->right && root->val == targetSum) { |
There was a problem hiding this comment.
個人的には targetSum - root->val をして、それを使ったほうが統一感がある気がしますね。
Owner
Author
There was a problem hiding this comment.
@oda
レビューありがとうございます。
確かに他の箇所はtargetSum - root->valとしているので修正しました。
oda
reviewed
Aug 19, 2024
| class Solution { | ||
| public: | ||
| bool hasPathSum(TreeNode* root, int targetSum) { | ||
| queue<NodeAndSum> candidates; |
There was a problem hiding this comment.
stack でもいいかもしれませんね。私はどちらでもいい場合は、stack を好みます。構造が単純なので。
Owner
Author
There was a problem hiding this comment.
@oda
一度覚えたqueueを使い回しておりました。
他の構造も使えないか検討しないとですね。stackでも実装してみました。
queueと同じくemplaceを採用しました。
|
拝見しました。 |
Owner
Author
|
@TORUS0818 |
kazukiii
reviewed
Aug 22, 2024
kazukiii
left a comment
kazukiii
left a comment
There was a problem hiding this comment.
既にコメントが付いているところ以外良いと思いました。読みやすかったです。
|
見ました！良いと思いました！ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
問題へのリンク
https://leetcode.com/problems/path-sum/description/
問題文(プレミアムの場合)
備考
次に解く問題の予告
Binary Tree Level Order Traversal
フォルダ構成
LeetCodeの問題ごとにフォルダを作成します。
フォルダ内は、step1.cpp、step2.cpp、step3.cpp、recursion.cppとrecursion_step2.cppとmemo.mdとなります。
memo.md内に各ステップで感じたことを追記します。