Skip to content

Demonstrate Hierarchy Functions #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
agoerler merged 33 commits into from
Dec 19, 2024
Merged

Demonstrate Hierarchy Functions #416

agoerler merged 33 commits into from
Dec 19, 2024

Conversation

@etimr
Copy link
Contributor

@etimr etimr commented Dec 18, 2024

Provides an example of an hierarchy function as ListReport and ValueHelp

"tableSettings": {
     "type": "TreeTable",
     "hierarchyQualifier": "NodesHierarchy",
   ...
}
  • to enable tree table for ValueHelp hierarchical entity should be annotated with PresentationVariant and root entity with PresentationVariantQualifier

etimr and others added 28 commits November 13, 2024 17:25
@etimr
WIP: Demonstrate Hierarchy Functions (#388)
16c919d 
Provides an example of an hierarchy function as `ListReport` and
`ValueHelp`
- currently only READ 
- only on HANA

Changes:
- `LineItem parent.name` is removed from `app/common.cds`, because it
leads to OData requests with `$expand` for an hierarchy function which
are not supported yet
- `sap.common.CodeList` aspect was removed from `Genres` entity because
it provides `ValueHelp` dialog implicitly through annotation
[@cds.odata.valuelist](https://pages.github.tools.sap/cap/docs/advanced/fiori#convenience-option-cds-odata-valuelist).
It also uses the annotation `@cds.autoexpose`, because of this entity
`Genres` should be exposed explicitly in `CatalogService` and
`ReviewService` after `sap.common.CodeList` is removed.
- renaming in the view `GenreHierarchy` is temporal and will be solved
by CAP Java team in the future
  ```
node   as node_id,
parent_node as parent_id
  ```
- to [enable tree
tables](https://ui5.sap.com//#/topic/7cf7a31fd1ee490ab816ecd941bd2f1f)
as `ListReport` add to `manifest.json`:
```
"tableSettings": {
     "type": "TreeTable",
     "hierarchyQualifier": "NodesHierarchy",
   ...
}
```
- to enable tree table for ValueHelp hierarchical entity should be
annotated with `PresentationVariant` and root entity with
`PresentationVariantQualifier`

---------

Co-authored-by: D070615 <olena.timrova@sap.com>
@etimr
Fix: ValueHelp Dialog (#397)
cb392f7 
Co-authored-by: D070615 <olena.timrova@sap.com>
@agoerler @etimr
Fix value help (#398)
2d8f6f8 
Co-authored-by: D070615 <olena.timrova@sap.com>
@agoerler
Update fiori-service.cds
1a037e3
@etimr
UI: Hide ID in ValueHelp (#399)
357611e 
Co-authored-by: D070615 <olena.timrova@sap.com>
@agoerler
Update to 3.5.0 & avoid parent_id/node_id projection
7b6179e
@etimr
Demonstrate custom logic for Tree Tables (#393)
c7f50a8
@agoerler
Merge remote-tracking branch 'origin/feature-tree-table' into avoidRe…
2897b41 
…name
@etimr
Support of ExpandLevels (#403)
45e6b03 
Support of ExpandLevels in custom code

---------

Co-authored-by: D070615 <olena.timrova@sap.com>
@agoerler
cleanup
7bf5397
@agoerler
Merge remote-tracking branch 'origin/feature-tree-table' into avoidRe…
4b5892d 
…name
@agoerler
No projection (#401)
cd01357
@agoerler
fix sorter
3cd209a
@agoerler
Merge remote-tracking branch 'origin/feature-tree-table' into avoidRe…
a8ea2f2 
…name
@etimr
added tests for GenreHierarchy
7e2153e
@agoerler
test in hybrid mode
ae813c2
@etimr
Test: added tests for GenreHierarchy (#404)
b8d8285
@agoerler
update test
3902076
@agoerler
Merge remote-tracking branch 'origin/feature-tree-table' into tree-ta…
9fe4f93 
…ble-test
@agoerler
Merge remote-tracking branch 'origin/main' into feature-tree-table
3a19bc0
@agoerler
parnt -> parent
903852e
@agoerler
Merge remote-tracking branch 'origin/main' into feature-tree-table
a6078cd
@agoerler
fix annotation
17354c9
@etimr
Added Tree Tables to Readme (#414)
ee8b025 
Co-authored-by: D070615 <olena.timrova@sap.com>
@etimr @eugene-andreev @agoerler
Test: added additional tests for GenreHierarchy (#413)
81bd62e 
Co-authored-by: D070615 <olena.timrova@sap.com>
Co-authored-by: Evgeny Andreev <evgeny.andreev@sap.com>
Co-authored-by: Adrian Görler <adrian.goerler@sap.com>
Co-authored-by: Evgeny Andreev <eugene.andreev@gmail.com>
@agoerler
fix import
a9db367
@eugene-andreev
more genres (#412)
333d2da
@agoerler
update to 3.6.0-m2451
b7953a0
@cla-assistant
Copy link

cla-assistant bot commented Dec 18, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@cla-assistant
Copy link

cla-assistant bot commented Dec 18, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ etimr
✅ agoerler
✅ eugene-andreev
❌ OlenaTi
You have signed the CLA already but the status is still pending? Let us recheck it.

agoerler
agoerler requested changes Dec 18, 2024
View reviewed changes
eugene-andreev
eugene-andreev reviewed Dec 18, 2024
View reviewed changes
@agoerler agoerler merged commit bde2090 into main Dec 19, 2024
1 of 2 checks passed
@agoerler agoerler deleted the feature-tree-table branch December 19, 2024 09:39
beckermarc
beckermarc reviewed Dec 19, 2024
View reviewed changes
db/books.cds
/**
* Hierarchically organized Code List for Genres
*/
entity Genres : sap.common.CodeList {
Copy link
Contributor

@beckermarc beckermarc Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't you use CodeList from sap.common?

Copy link
Contributor

@agoerler agoerler Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OlenaTi - do you recall why we changed this?

Copy link
Contributor

@agoerler agoerler Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-> https://github.com/SAP-samples/cloud-cap-samples-java/pull/419/files#diff-d92b8eb29957a03ad9d23b01feff79da293e30183d0b8eac5d893d95632e30dfR51

Copy link
Contributor Author

@etimr etimr Dec 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

short version: because it provides a standart ValueHelp dialog and doesn't allow to customize it for Tree Tables,
a little bit more explained: #388 (comment)

beckermarc
beckermarc reviewed Dec 19, 2024
View reviewed changes
README.md

### Testing in hybrid mode

You can test the `GenreHierarchyTest` on H2 using the profile `default` as well as on HANA using the profile `hybrid`
Copy link
Contributor

@beckermarc beckermarc Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather recommend usage of existing profiles in application.yaml, e.g. cloud, which expects HANA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agoerler agoerler agoerler approved these changes

@eugene-andreev eugene-andreev eugene-andreev left review comments

@beckermarc beckermarc beckermarc left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@etimr @agoerler @eugene-andreev @beckermarc