Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ jobs:
uses: actions/checkout@v5

- name: Set up Node.js for Frontend build
uses: actions/setup-node@v5
uses: actions/setup-node@v6
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider verifying that actions/setup-node@v6 is compatible with your current workflow requirements. While updating to the latest version is generally good practice, ensure you've tested that this version works correctly with Node.js 24 and your npm caching configuration. You may want to check the action's changelog for any breaking changes.

with:
node-version: '24'
cache: 'npm'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/fe-installation-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
uses: actions/checkout@v5

- name: Set up Node.js environment
uses: actions/setup-node@v5
uses: actions/setup-node@v6
with:
node-version: "24"

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lint-frontend.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
uses: actions/checkout@v5

- name: Set up Node.js
uses: actions/setup-node@v5
uses: actions/setup-node@v6
with:
node-version: 24
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent Node.js version format across workflow files. This file uses a number format (24) while other files use string format ('24'). For consistency and to follow GitHub Actions best practices, use string format:

node-version: '24'


Expand Down