Skip to content

chore: enable Reproducible Builds#406

Merged
Jonas-Isr merged 2 commits intoSAP:mainfrom
hboutemy:reproducible-builds
Apr 4, 2025
Merged

chore: enable Reproducible Builds#406
Jonas-Isr merged 2 commits intoSAP:mainfrom
hboutemy:reproducible-builds

Conversation

@hboutemy
Copy link
Copy Markdown
Contributor

@hboutemy hboutemy commented Apr 3, 2025

Context

Activate Reproducible Builds: https://maven.apache.org/guides/mini/guide-reproducible-builds.html

Feature scope:

  • add timestamp
  • update jar plugin (do not rely on default version provided by Maven)

Definition of Done

  • Functionality scope stated & covered
  • Tests cover the scope above
  • Error handling created / updated & covered by the tests above
  • Aligned changes with the JavaScript SDK
  • Documentation updated
  • Release notes updated

@cla-assistant
Copy link
Copy Markdown

cla-assistant bot commented Apr 3, 2025

CLA assistant check
All committers have signed the CLA.

@Jonas-Isr Jonas-Isr changed the title enable Reproducible Builds chore: enable Reproducible Builds Apr 4, 2025
Copy link
Copy Markdown
Member

@Jonas-Isr Jonas-Isr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future reference: Since the actual release-commits are not present in the commit history (due to us using squash merges), in order to reproduce the release build, one has to use the commit that includes the release-commit and then revert some of the changes (should be enough to set the sdk version back to x.y.z, i.e., removing -SNAPSHOT).

To build the release, we use mvn clean install -DskipTests.

@Jonas-Isr Jonas-Isr merged commit 6e64e63 into SAP:main Apr 4, 2025
4 checks passed
@hboutemy hboutemy deleted the reproducible-builds branch April 4, 2025 15:53
rpanackal added a commit that referenced this pull request Aug 8, 2025
* Generate client and successful compilation

* Update pr-lint.yaml

* Changes from PR #406 - fix: spec consistency issues in rage proxy

* Regenerate models and add release notes.

* Release notes formatting

* Release notes formatting

---------

Co-authored-by: Roshin Rajan Panackal <roshin.rajan.panackal@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants