feat: Implementing minimal feature scope for Spring AI integration in OpenAI by n-o-u-r-h-a-n · Pull Request #526 · SAP/ai-sdk-java

n-o-u-r-h-a-n · 2025-08-05T15:29:28Z

Context

AI/ai-sdk-java-backlog#179.

Integrating SpringAi with our OpenAiClient.

Feature scope:

Implementation of Chat Completion, Stream Chat Completion, Tool Calling and Chat Memory in SpringAiOpenAiService.
Making OpenAiChatOptions accept a config parameter using a new approach.
- Creation of a new class : OpenAiChatCompletionConfig.
- Updating OpenAiChatCompletionRequest for integration with OpenAiChatCompletionConfig class.
- Updating OpenAiChatOptions accordingly as well(aligned with orchestration).

Definition of Done

Functionality scope stated & covered
Tests cover the scope above
Error handling created / updated & covered by the tests above
~~Aligned changes with the JavaScript SDK~~
Documentation updated
Release notes updated

… 1.0.0 (GA Version) (#503)"

… AI 1.0.0 (GA Version) (#503)".

…AiService + their corresponding passed tests in SpringAiOpenAiTest class. Regarding the OpenAiChatModel class it was just formatting, nothing changed.

--> 4 methods in OpenAiChatCompletionRequest.java return only this now and other constructors other than main are removed for now.

…ringopenai # Conflicts: # core/src/main/java/com/sap/ai/sdk/core/common/ClientResponseHandler.java

…est.java failing. --> still fix of null of message.getText() in toAssistantMessage() method in OpenAiChatModel.java pending.

# Conflicts: # sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/services/SpringAiAgenticWorkflowService.java

… into chatcompletion-for-springopenai

newtork

Looks good to me, please have another reviewer- because I'm one of the contributors.

Please find my PR to reduce constructor visibility again in your branch:
#531

sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/services/SpringAiOpenAiService.java

...dels/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/OpenAiAssistantMessage.java

...openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/OpenAiChatCompletionRequest.java

.../openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/OpenAiChatCompletionConfig.java

...n-models/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/OpenAiFunctionCall.java

...ls/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/spring/OpenAiChatOptions.java

rpanackal · 2025-08-12T08:54:43Z

...ls/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/spring/OpenAiChatOptions.java

+  public <T extends ChatOptions> T copy() {
+    final OpenAiChatOptions copy = new OpenAiChatOptions();
+    copy.setToolCallbacks(this.toolCallbacks);
+    copy.setInternalToolExecutionEnabled(this.internalToolExecutionEnabled);
+    copy.setTools(this.tools);
+    copy.setToolNames(this.toolNames);
+    copy.setToolContext(this.toolContext);
+    return (T) copy;
+  }


(Minor)

Please also copy the config and any other fields that was missed

* Reduce constructors * Update thresholds * Update javadoc and factory name

…to withStop() method.

… into chatcompletion-for-springopenai

Jonas-Isr and others added 29 commits June 16, 2025 17:44

first draft

9ff262b

Align with docs

b14d70c

Codestyle

b32b999

Merge branch 'main' into agent-workflow-examples

32d1bb2

Merge branch 'main' into agent-workflow-examples

5720581

Merge branch 'main' into agent-workflow-examples

64c8b0e

Merge branch 'main' into agent-workflow-examples

98ab1af

feat: [OpenAI] Spring AI integration

0e59667

test

71898c5

Merge branch 'agent-workflow-examples' into openai-springai

b056414

test

025eba1

Merge branch 'agent-workflow-examples' into openai-springai

d402c64

Merge branch 'main' into openai-springai

7ed6baa

Fixing errors in OpenAiChatOptions according to "Upgrade to Spring AI…

3b0273b

… 1.0.0 (GA Version) (#503)"

Fixing errors in OpenAiChatOptions according to "Upgrade to Spring AI…

8c2a638

… 1.0.0 (GA Version) (#503)"

Fixing SpringAiAgenticWorkflowService according to "Upgrade to Spring…

8eb5459

… AI 1.0.0 (GA Version) (#503)".

Implementation of completion and streamChatCompletion in SpringAiOpen…

ab1f795

…AiService + their corresponding passed tests in SpringAiOpenAiTest class. Regarding the OpenAiChatModel class it was just formatting, nothing changed.

Removing a comment

9d4bdcd

Removing a comment

72198d9

Chat Memory test working.

88904c8

Formatting for SpringAiOpenAiService.

47d1bc0

Removing unneccessary imports in SpringAiOpenAiService.

443e464

Updating the toOpenAiRequest in OpenAiChatModel.java.

00ba4ad

Implementing the new approach

55c85d9

--> 4 methods in OpenAiChatCompletionRequest.java return only this now and other constructors other than main are removed for now.

Editing the approach.

56cda93

Fix compilation and format and annotations and javadoc

0183c83

Merge remote-tracking branch 'origin/main' into chatcompletion-for-sp…

02d5f54

…ringopenai # Conflicts: # core/src/main/java/com/sap/ai/sdk/core/common/ClientResponseHandler.java

Remove unrelated code

ee94941

implementation hint

dec85d6

n-o-u-r-h-a-n requested a review from rpanackal August 5, 2025 15:29

Resolving Reviewed Issues.

f7c7ece

n-o-u-r-h-a-n removed the request for review from rpanackal August 7, 2025 17:03

n-o-u-r-h-a-n and others added 13 commits August 7, 2025 19:44

Resolving Reviewed Issues.

84546c0

--> still having testToolCallingWithoutExecution() in SpringAiOpenAiT…

c52720e

…est.java failing. --> still fix of null of message.getText() in toAssistantMessage() method in OpenAiChatModel.java pending.

format

cd3501c

format

7f447d7

Removing wild cards imports

9e1760c

Sucessful build of OpenAi

222924c

Sucessful build of Spring Boot app.

de9ef56

Merge branch 'main' into chatcompletion-for-springopenai

9fb6321

# Conflicts: # sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/services/SpringAiAgenticWorkflowService.java

Formatting

9284fe3

Removing this test for now.

8d40dfa

Fix nullcheck

be51dd3

Merge remote-tracking branch 'origin/chatcompletion-for-springopenai'…

d0ea158

… into chatcompletion-for-springopenai

Fix unit test

3c161c0

newtork mentioned this pull request Aug 8, 2025

chore: Reduce constructor visibility in OpenAI / SpringAI PR #531

Merged

newtork reviewed Aug 8, 2025

View reviewed changes

Merge branch 'main' into chatcompletion-for-springopenai

35d89cb

n-o-u-r-h-a-n requested a review from rpanackal August 11, 2025 11:43

n-o-u-r-h-a-n mentioned this pull request Aug 11, 2025

Java 1.11.0: OpenAI SpringAI Integration SAP/ai-sdk#199

Merged

rpanackal reviewed Aug 12, 2025

View reviewed changes

newtork and others added 5 commits August 12, 2025 17:49

chore: Reduce constructor visibility in OpenAI / SpringAI PR (#531)

c186aea

* Reduce constructors * Update thresholds * Update javadoc and factory name

Replacing config.toolsExecutable with getter-usage + adding tolerate …

75a2361

…to withStop() method.

Merge remote-tracking branch 'origin/chatcompletion-for-springopenai'…

ddcb88c

… into chatcompletion-for-springopenai

Merge branch 'main' into chatcompletion-for-springopenai

9f27cb4

Merge branch 'main' into chatcompletion-for-springopenai

3e3d41a

newtork added the dont-merge label Aug 14, 2025

CharlesDuboisSAP closed this Aug 19, 2025

CharlesDuboisSAP deleted the chatcompletion-for-springopenai branch August 19, 2025 10:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Implementing minimal feature scope for Spring AI integration in OpenAI#526

feat: Implementing minimal feature scope for Spring AI integration in OpenAI#526
n-o-u-r-h-a-n wants to merge 58 commits intomainfrom
chatcompletion-for-springopenai

n-o-u-r-h-a-n commented Aug 5, 2025 •

edited

Loading

Uh oh!

newtork left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rpanackal Aug 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

n-o-u-r-h-a-n commented Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Context

Feature scope:

Definition of Done

Uh oh!

newtork left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rpanackal Aug 12, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

n-o-u-r-h-a-n commented Aug 5, 2025 •

edited

Loading