Conversation
Jonas-Isr
commented
Feb 18, 2026
...odels/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/OpenAiClientException.java
Show resolved
Hide resolved
Jonas-Isr
commented
Feb 18, 2026
| * href="https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/http/converter/json/Jackson2ObjectMapperBuilder.html">Jackson2ObjectMapperBuilder</a> | ||
| */ | ||
| @Nonnull | ||
| @Beta |
Member
Author
There was a problem hiding this comment.
There is already a class-level beta annotation
newtork
reviewed
Feb 19, 2026
newtork
reviewed
Feb 19, 2026
| */ | ||
| @Beta | ||
| @Nonnull | ||
| public OpenAiClient withApiVersion(@Nonnull final String apiVersion) { |
Contributor
There was a problem hiding this comment.
(Minor)
While I like the API and implementation, I do wonder whether the Beta annotation was used to discourage the usage. If I recall correctly we actually did not want users to use that method - right? We could check back with PO. Maybe there is a productive use-case for that.
Member
Author
There was a problem hiding this comment.
If I recall correctly we actually did not want users to use that method - right?
I don't remember this. But maybe someone else?
Member
Author
There was a problem hiding this comment.
I asked Junjie as well, he does not know of any use-case. So I will keep @Beta here to discourage usage.
newtork
reviewed
Feb 19, 2026
...ion/src/main/java/com/sap/ai/sdk/orchestration/spring/OrchestrationSpringEmbeddingModel.java
Show resolved
Hide resolved
newtork
reviewed
Feb 19, 2026
orchestration/src/main/java/com/sap/ai/sdk/orchestration/ContentFilter.java
Show resolved
Hide resolved
newtork
reviewed
Feb 19, 2026
newtork
reviewed
Feb 19, 2026
orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationFilterException.java
Show resolved
Hide resolved
newtork
reviewed
Feb 19, 2026
rpanackal
reviewed
Feb 19, 2026
core/src/main/java/com/sap/ai/sdk/core/common/ClientResponseHandler.java
Show resolved
Hide resolved
...odels/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/OpenAiClientException.java
Show resolved
Hide resolved
orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationClientException.java
Show resolved
Hide resolved
orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationClientException.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
As discussed, this PR challenges some of our current
@Betatags.For the ones I did not add a specific comment, I thought the API is fairly established and major changes are unlikely. For all other cases I added some reasoning.
The
@Betatags on the...Apiand...Clientclasses stay since they are more or less just wrappers around generated code.The other
@Betatags I left in where either because they were on pretty new classes/API or because they were on internally used methods and classes.