feat: [Orchestration] support the file uploading feature#818
Open
n-o-u-r-h-a-n wants to merge 9 commits intomainfrom
Open
feat: [Orchestration] support the file uploading feature#818n-o-u-r-h-a-n wants to merge 9 commits intomainfrom
n-o-u-r-h-a-n wants to merge 9 commits intomainfrom
Conversation
newtork
reviewed
Apr 8, 2026
sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/controllers/OrchestrationTest.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Apr 8, 2026
orchestration/src/main/java/com/sap/ai/sdk/orchestration/ContentItem.java
Outdated
Show resolved
Hide resolved
Jonas-Isr
reviewed
Apr 8, 2026
sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/controllers/OrchestrationTest.java
Outdated
Show resolved
Hide resolved
orchestration/src/test/java/com/sap/ai/sdk/orchestration/OrchestrationConvenienceUnitTest.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Apr 8, 2026
| * @param filename name of the file | ||
| * @since 1.18.0 | ||
| */ | ||
| public record FileItem(@Nonnull String fileData, @Nonnull String filename) implements ContentItem {} |
Contributor
There was a problem hiding this comment.
(Question)
The specification assumes Base64 encoded file content or file URL for fileData.
But your implementation only assumes local file content, right? Can your API still support remote files? Or is it out-of-scope?
Maybe we need a LocalFileItem and RemoteFileItem 🤔
Contributor
Author
There was a problem hiding this comment.
Yes, my implementation assumed only local file content, but because I understood that remote files support is out-of-scope.
I searched now and found this information on SAP Help Portal, but I'm a bit confused. Does that mean remote files should be supported as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
AI/ai-sdk-java-backlog#375.
Orchestration service releases a new service for file uploading(PDF), so the feature is now supported.
Feature scope:
Definition of Done
Aligned changes with the JavaScript SDK