feat: [OpenAI] An AiCore wrapper for Responses API only#819
Open
rpanackal wants to merge 34 commits intofeat/poc-openai-responses-apachefrom
Open
feat: [OpenAI] An AiCore wrapper for Responses API only#819rpanackal wants to merge 34 commits intofeat/poc-openai-responses-apachefrom
rpanackal wants to merge 34 commits intofeat/poc-openai-responses-apachefrom
Conversation
- Streaming no fully enabled
… API creation forModel
…openai-wrapper # Conflicts: # foundation-models/openai/pom.xml # foundation-models/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/AiCoreOpenAiClient.java # foundation-models/openai/src/test/java/com/sap/ai/sdk/foundationmodels/openai/AiCoreOpenAiClientTest.java # pom.xml # sample-code/spring-app/src/main/java/com/sap/ai/sdk/app/services/AiCoreOpenAiService.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
AI/ai-sdk-java-backlog#364.
An alternative to #806
The above mentioned PR introduced wrapper for all openai endpoints and failed to scale. So, we have stripped down the scope of the wrapper to be limited to Responses API alone.
The motivation for this decision is because, the OpenAI SDK integration is not decidedly "the way to go" but an approach that enables Responses API until we can support code generation for OAS3.2, the original blocker for OpenAI Responses API.
Feature scope:
AiCoreOpenAiClient.response(OpenAiModel.GPT_5)returns a wrapperAiCoreResponseServiceAiCoreResponseServiceprovides model injection if left out in params and throws there is a model mismatch against deployment modelDefinition of Done
Error handling created / updated & covered by the tests aboveAligned changes with the JavaScript SDKDocumentation updatedRelease notes updated