feat: Add jks to supported formats #6153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidkna-sap
previously requested changes
Nov 13, 2025
| if (aliases.length === 0) { | ||
| throw Error('No entries found in JKS keystore'); | ||
| } | ||
| const alias = aliases[0]; // Use first alias |
Member
There was a problem hiding this comment.
[q] How does the java sdk handle multiple keys?
[pp] If supporting multiple keys is not a requirement, I would also throw if aliases.length > 1.
Collaborator
There was a problem hiding this comment.
I checked this in Java, all private keys are loaded into the key manager.
For now, as the original issue is solved with the current implementation, we can create a follow-up to handle multiple aliases.
IMO, all the aliases can be returned as Node.JS TLS https://nodejs.org/api/tls.html#tls_tls_createsecurecontext_options seems to support multiple cert chains.
davidkna-sap
reviewed
Dec 3, 2025
Co-authored-by: David Knaack <david.knaack@sap.com>
davidkna-sap
reviewed
Dec 3, 2025
davidkna-sap
reviewed
Dec 3, 2025
Co-authored-by: David Knaack <david.knaack@sap.com>
KavithaSiva
requested changes
Dec 10, 2025
Collaborator
KavithaSiva
left a comment
KavithaSiva
left a comment
There was a problem hiding this comment.
I have left two comments to work on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes SAP/ai-sdk-js-backlog#358.