Skip to content

Use new debian bookworm base image#58

Merged
o-liver merged 2 commits intomasterfrom
o-liver-patch-1
Aug 3, 2023
Merged

Use new debian bookworm base image#58
o-liver merged 2 commits intomasterfrom
o-liver-patch-1

Conversation

@o-liver
Copy link
Member

@o-liver o-liver commented Jul 28, 2023

Also upgraded mta plugin version to latest

Also upgraded mta plugin version to latest
@o-liver
Copy link
Member Author

o-liver commented Jul 28, 2023

@radsoulbeard Is the Infrastructure test still valid. I see it tries to run this Jenkinsfile, which uses the old sdk pipeline library v24.

@o-liver
Copy link
Member Author

o-liver commented Jul 28, 2023

I see we had this discussion about the Infrastructure Tests already in PR #55 Time to remove those tests. Would be nice to replace them with something else though. Would it be enough to pull the image and do a cf --version check inside the container?

@o-liver o-liver requested a review from srinikitha09 August 2, 2023 07:56
@srinikitha09
Copy link
Contributor

Did you have a chance to test these changes on one of our reference apps?

@o-liver
Copy link
Member Author

o-liver commented Aug 2, 2023

Did you have a chance to test these changes on one of our reference apps?

No, is that best practice? I should build it myself and test it? I would do so locally in that case, not with our service.

@o-liver
Copy link
Member Author

o-liver commented Aug 2, 2023

I would argue that we should keep the image up to date in any case. Testing it on one of our sample applications does not prove much and this update is necessary anyhow: We cannot stay on an old debian; We should not let the plugins used get old.

@srinikitha09
Copy link
Contributor

Did you have a chance to test these changes on one of our reference apps?

No, is that best practice? I should build it myself and test it? I would do so locally in that case, not with our service.

AFAIK, that is how we do so that we are aware of the issues beforehand.

@srinikitha09
Copy link
Contributor

I would argue that we should keep the image up to date in any case. Testing it on one of our sample applications does not prove much and this update is necessary anyhow: We cannot stay on an old debian; We should not let the plugins used get old.

Yes, agree, but still it would be worthy to test it on our side as well.

@o-liver
Copy link
Member Author

o-liver commented Aug 2, 2023

Ok, I will do so and let you know

@o-liver
Copy link
Member Author

o-liver commented Aug 2, 2023

I would argue that we should keep the image up to date in any case. Testing it on one of our sample applications does not prove much and this update is necessary anyhow: We cannot stay on an old debian; We should not let the plugins used get old.

Yes, agree, but still it would be worthy to test it on our side as well.

Tested it locally and it works:

  • cf login works
  • cf deploy of mta archive works

Copy link
Contributor

@srinikitha09 srinikitha09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@o-liver o-liver merged commit d923f0a into master Aug 3, 2023
@o-liver o-liver deleted the o-liver-patch-1 branch August 3, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants