Skip to content

Update version of multiapps plugin to 3.1.1#60

Merged
o-liver merged 1 commit intoSAP:masterfrom
theghost5800:patch-1
Oct 19, 2023
Merged

Update version of multiapps plugin to 3.1.1#60
o-liver merged 1 commit intoSAP:masterfrom
theghost5800:patch-1

Conversation

@theghost5800
Copy link
Contributor

@theghost5800 theghost5800 commented Oct 18, 2023

No description provided.

@boyan-velinov
Copy link
Contributor

boyan-velinov commented Oct 18, 2023

The change is required because there is a high chances of problems during upload of larger MTA archives to MTA Deployment Service. This is due to recent changes in MTA deployment Service backend related to the file processing so the end customer might experience problems like:
info cloudFoundryDeploy - Error occurred: Post "https://deploy-service.cf.eu10.hana.ondemand.com/api/v1/spaces/<space-guid>/files": retry is needed. Retrying after: 3s.

WIth the MultiApps CF CLI plugin version v3.1.1 there is improved and more stable mechanism in regards of the upload of MTA arhive whichmitigates the risk for larger MTA archives upload and/or latency:
https://github.com/cloudfoundry/multiapps-cli-plugin/releases/tag/v3.1.1

With the previous versions of MultiApps CF CLI plugin file chunks were uploaded in parallel which might be faster in some cases but there was increased possibility of problems during upload.
With the version 3.1.1 the default behavior is to perform sequential file chunks upload.
The parallel file upload can be switched on again with env variable MULTIAPPS_UPLOAD_CHUNKS_IN_PARALLEL

Let's consider to provide version v3.1.1. of MultiApps CF CLI plugin to all customers as quickly as possible.

Copy link
Member

@o-liver o-liver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that!

@o-liver
Copy link
Member

o-liver commented Oct 18, 2023

@theghost5800 I believe you might need to accept the license/cla for this PR to be mergable.

@theghost5800
Copy link
Contributor Author

@o-liver I don't see how I can accept the license/cla? Could you please provide a link.

@o-liver
Copy link
Member

o-liver commented Oct 18, 2023

@o-liver I don't see how I can accept the license/cla? Could you please provide a link.

I don't know, unfortunately. I will solve it now by providing a new PR. Seems as if one cannot simply open a PR from a fork.
Do you know of this issue @radsoulbeard ?

@o-liver o-liver mentioned this pull request Oct 18, 2023
@o-liver
Copy link
Member

o-liver commented Oct 18, 2023

Me opening the PR did not fix the issue. I will investigate ASAP.

@o-liver
Copy link
Member

o-liver commented Oct 18, 2023

@theghost5800 Could you try with this link if it helps? https://cla-assistant.io/SAP/devops-docker-cf-cli?pullRequest=60

@theghost5800
Copy link
Contributor Author

@o-liver I had tried to sign the license multiple times but it looks like it doesn't work, check it's still present. When I go to the provided link, I can see now "You have agreed to the CLA for SAP/devops-docker-cf-cli".

@o-liver
Copy link
Member

o-liver commented Oct 19, 2023

@o-liver I had tried to sign the license multiple times but it looks like it doesn't work, check it's still present. When I go to the provided link, I can see now "You have agreed to the CLA for SAP/devops-docker-cf-cli".

Same for me, I need to find out what is going on here! Will keep you posted.

@o-liver o-liver merged commit a59af0d into SAP:master Oct 19, 2023
@srinikitha09
Copy link
Contributor

MultiApps CF CLI p

Is this a new change that we need to do now?

@anilkeshav27
Copy link
Member

@o-liver , is there a new docker image released ? or are the changes under ppiper/cf-cli:latest , so piper does not change ?

@o-liver
Copy link
Member

o-liver commented Oct 19, 2023

@o-liver , is there a new docker image released ? or are the changes under ppiper/cf-cli:latest , so piper does not change ?

@anilkeshav27 In the Piper Cloud Foundry steps we are using the latest tag, so we will automatically use the new release.

@DanielMieg @tiloKo @ranliii In the ABAP steps you are fixed on ppiper/cf-cli:v12, which is one year old. We are now at v16, maybe this is something you want to update.

@theghost5800 theghost5800 deleted the patch-1 branch October 26, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants