Skip to content

Add multiapps cli plugin user_agent header suffix #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
IvanBorislavovDimitrov wants to merge 1 commit into from
Closed

Add multiapps cli plugin user_agent header suffix #79

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ RUN apt-get update && \
ARG USER_HOME=/home/piper
RUN addgroup -gid 1000 piper && \
useradd piper --uid 1000 --gid 1000 --shell /bin/bash --home-dir "${USER_HOME}" --create-home

ARG INSTALL_DIR=/usr/local/bin
RUN curl --location --silent "https://packages.cloudfoundry.org/stable?release=linux64-binary&version=v8&source=github" | tar -zx -C "${INSTALL_DIR}" && \
cf --version
Expand All @@ -31,6 +31,7 @@ RUN curl https://cli.btp.cloud.sap/btpcli-install.sh | bash -s -- -o "${INSTALL_
USER piper
WORKDIR ${USER_HOME}

ENV MULTIAPPS_USER_AGENT_SUFFIX="ppiper/cf-cli:${VERSION}"
Copy link
Contributor

@theghost5800 theghost5800 Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does VERSION env change during builds of the image? Because in latest tag it's still set to "0.1"

ARG MTA_PLUGIN_VERSION=3.6.0
Copy link
Contributor

@theghost5800 theghost5800 Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to adopt 3.7.0 version before this change

ARG MTA_PLUGIN_URL=https://github.com/cloudfoundry/multiapps-cli-plugin/releases/download/v${MTA_PLUGIN_VERSION}/multiapps-plugin.linux64
ENV MULTIAPPS_DISABLE_UPLOAD_PROGRESS_BAR=true
Expand Down