Skip to content

[FIX] Adapt to recent extension of estraverse's set of node types #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matz3 merged 2 commits into from
Aug 14, 2019
+9 −5
Merged

[FIX] Adapt to recent extension of estraverse's set of node types #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9857e10
[FIX] Adapt to recent extension of estraverse's set of node types
codeworrior Aug 14, 2019
93fb862
Update package*.json
codeworrior Aug 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/lbt/analyzer/JSModuleAnalyzer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ const EnrichedVisitorKeys = (function() {
* E.g. in an IfExpression, the 'test' is always executed, whereas 'consequent'
* and 'alternate' are only executed under certain conditions.
*
* While visiting the AST of a JavaSCript file, the JSModuleAnalyzer uses this information
* While visiting the AST of a JavaScript file, the JSModuleAnalyzer uses this information
* to decide whether a code block is executed conditionally or unconditionally.
* Besides this information which is inherent to the language, the analyzer uses
* additional knowledge about special APIS / constructs (e.g. the factory function of
Expand Down Expand Up @@ -103,6 +103,10 @@ const EnrichedVisitorKeys = (function() {
* import >>>a<<< from 'module';
*/
ImportDefaultSpecifier: [], // local
/*
* Dynamic Import expression, the argument is evaluated unconditionally.
*/
ImportExpression: [], // source,
/*
* import >>>* as b<<< from 'module';
*/
Expand Down
6 changes: 3 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@
"escodegen": "^1.11.1",
"escope": "^3.6.0",
"esprima": "^4.0.1",
"estraverse": "^4.2.0",
"estraverse": "^4.3.0",
"globby": "^10.0.1",
"graceful-fs": "^4.2.1",
"jsdoc": "3.5.5",
Expand Down