Fix spline generation issue involving trace isotopes of elements that use a spectral function nuclear model #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
optionally approximated by a spectral function for a different isotope of the same element. Enable this behavior in the AR25 tunes.
kjplows
approved these changes
Oct 30, 2025
kjplows
left a comment
kjplows
left a comment
There was a problem hiding this comment.
Can confirm that:
--> SpectralFunc asks the Ar40 data file to produce Ar39 when ApproxElements is enabled. (Testing with 13C, and 17O)
--> The key correctly enters fSpectralFunctionMap
--> Spline generation exits normally and splines are readable
Many thanks @sjgardiner !!
|
To follow up, oxygen and carbon SF work well too :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the SpectralFunc class so that a missing spectral function can be optionally approximated by a spectral function for a different isotope of the same element. Enable this behavior in the AR25 tunes.