Tuned Simulated Field Responses #572
Conversation
…rable by fcl. Add in config for 'fit' field responses.
rennney
left a comment
rennney
left a comment
There was a problem hiding this comment.
Changes a great, I have slight concerns about elec response parameters would work correctly through this definition; however, I assume you've tested it and if it works that is great!
If you have some time, please also add your changes to https://github.com/SBNSoftware/icaruscode/blob/develop/icaruscode/TPC/ICARUSWireCell/icarus/wct-sim-check.jsonnet . This jsonnet file is sort of bookkeeping WC check that would work without larsoft and it is good to keep it up to date.
|
@rennney thanks! I think you were right to be worried about the elec response parameters. I just checked and found an issue, which is now fixed. And I'll update the config you linked. |
|
This is ready to go -- for validation, see docdb 31264. |
…r 2D drift." This reverts commit bc9bb19090bb9e96735dff2ac43610d42cdd366e.
|
trigger build LArSoft/lar*@LARSOFT_SUITE_v09_72_00 SBNSoftware/sbncode@v09_72_00_03 SBNSoftware/sbnanaobj@v09_20_06 SBNSoftware/sbndaq-artdaq-core@v1_06_00of0 SBNSoftware/sbnobj@v09_16_00 SBNSoftware/icarus_signal_processing@v09_63_00_02 SBNSoftware/icarusalg@v09_72_00 SBNSoftware/icarusutil@v09_66_02 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
|
trigger build LArSoft/lar*@LARSOFT_SUITE_v09_72_00 SBNSoftware/sbncode@v09_72_00_03 SBNSoftware/sbnanaobj@v09_20_06 SBNSoftware/sbndaq-artdaq-core@v1_06_00of0 SBNSoftware/sbnobj@v09_16_00 SBNSoftware/icarus_signal_processing@v09_63_00_02 SBNSoftware/icarusalg@v09_72_00 SBNSoftware/icarusutil@v09_66_02 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
|
trigger build LArSoft/lar*@LARSOFT_SUITE_v09_72_00 SBNSoftware/sbncode@v09_72_00_03 SBNSoftware/sbnanaobj@v09_20_06 SBNSoftware/sbndaq-artdaq-core@v1_06_00of0 SBNSoftware/sbnobj@v09_16_00 SBNSoftware/icarus_signal_processing@v09_63_00_02 SBNSoftware/icarusalg@v09_72_00 SBNSoftware/icarusutil@v09_66_02 |
|
✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
Extends the WireCell jsonnet configuration to make more parameters configurable. Adds in a configuration to simulate the "tuned" signal response.
I have validated that the nominal configuration produces the exact same JSON output as before this PR.
Notes:
-I am putting this into draft form for now since we still may be tuning some things like the gain
-This will also require an update to icarus_data to add in the new field response file