Skip to content

Reverts a commit of snippet3DHitBuilder which is on a feature branch and not ready for prime time #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mmrosenberg merged 1 commit into from
Jun 2, 2023
Merged

Reverts a commit of snippet3DHitBuilder which is on a feature branch and not ready for prime time #591

mmrosenberg merged 1 commit into from
Jun 2, 2023

Conversation

@SFBayLaser
Copy link
Contributor

@SFBayLaser SFBayLaser commented Jun 2, 2023

This somehow snuck into another PR (even after reverted) and into a tagged release... sigh...

@SFBayLaser
This reverts a change to snippetHit3DBuilderICARUS that is on a featu…
65b82ae 
…re branch but not ready for prime time, somehow included in a PR...
@mmrosenberg
Copy link
Contributor

mmrosenberg commented Jun 2, 2023

trigger build

@FNALbuild
Copy link
Collaborator

FNALbuild commented Jun 2, 2023

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Jun 2, 2023

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Jun 2, 2023

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for c7:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Jun 2, 2023

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e20:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@mmrosenberg mmrosenberg merged commit be85e9b into develop Jun 2, 2023
@mmrosenberg mmrosenberg deleted the feature/usher_revertsnippit3DHitBuilder branch June 2, 2023 21:38
@SFBayLaser SFBayLaser restored the feature/usher_revertsnippit3DHitBuilder branch June 6, 2023 20:11
@SFBayLaser SFBayLaser deleted the feature/usher_revertsnippit3DHitBuilder branch June 6, 2023 20:12
SFBayLaser added a commit that referenced this pull request Jun 7, 2023
@SFBayLaser
This is the commit for PR #591 which reverts and inadvertent add of t…
fec80fb 
…he 3D hit building
@SFBayLaser
Copy link
Contributor Author

SFBayLaser commented Jun 7, 2023

trigger build LArSoft/lar*@LARSOFT_SUITE_v09_72_00 SBNSoftware/sbncode@v09_72_00_03 SBNSoftware/sbnanaobj@v09_20_06 SBNSoftware/sbndaq-artdaq-core@v1_06_00of0 SBNSoftware/sbnobj@v09_16_00 SBNSoftware/icarus_signal_processing@v09_63_00_02 SBNSoftware/icarusalg@v09_72_00 SBNSoftware/icarusutil@v09_66_02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SFBayLaser @mmrosenberg @FNALbuild