Changes needed for YZ simulation #784
Conversation
SFBayLaser
left a comment
SFBayLaser
left a comment
There was a problem hiding this comment.
At this point I believe this PR is being held captive waiting for the updated WireCell Toolkit.
There was a problem hiding this comment.
Looks good! One note here -- we'll have to tune time_offset_{u, v, y} parameters with the new signal shape simulation going in. Not something that should hold up the PR, but a validation step we should do once we merge it in. @brucehoward-physics has a study we did to do this previously.
gputnam
left a comment
gputnam
left a comment
There was a problem hiding this comment.
Looks great overall! Couple questions / suggestions. Could also be ignored to merge in if there is urgency.
There was a problem hiding this comment.
Is the only difference here the "-shifted" jsonnet? Could you #include the base file instead and override this parameter?
There was a problem hiding this comment.
I won't hold this up, but I'm pretty sure you could clean up this code with some std.range calls: https://jsonnet.org/ref/stdlib.html.
There was a problem hiding this comment.
Ok another note here (which should not hold up the review). We'll need to replace these with the ICARUSDrifters that I made (#782) to lookup the electron lifetime from the SQLite file.
| name: "scaler%d" %n, //%std.floor(n/45), | ||
| data: params.lar { | ||
| yzmap_scale_filename: 'yzmap_gain_icarus_v2_run2.json', | ||
| bin_width: 10*wc.cm, |
There was a problem hiding this comment.
How does this handle depositions that are outside the binning of the YZ maps? I don't think I included the whole TPC when I made those.
There was a problem hiding this comment.
What's the difference between this config and the non-shifted one?
There was a problem hiding this comment.
Is this one not -refactored? Do we need it? I don't see it referenced by a fcl file.
|
another question, given a pending WireCell toolkit change... is this PR in need of that update or can it go ahead? |
|
The PR is ok to me even without the comments being resolved. |
|
Gray's branch integrates all this in a much better way. |
This PR will enable the variation of the signal shapes and gain across the YZ plane as measured for Run2. The support is in here to also model the electron lifetime separately in each cryostat (or TPC, or YZ bin).
To fully use all these features the following PRs will also be required to be merged:
This simulation has been validated by @gputnam and @mrmooney (Thanks!)
This might require a patch once we reorganize all of our fcl files but the base line simulation is intended to consume "shifted" SimEnergyDeposits from the refactored LArG4.