remove legacy G4 files, introduce standard fcl directory #809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SFBayLaser
reviewed
Mar 27, 2025
Contributor
SFBayLaser
left a comment
SFBayLaser
left a comment
There was a problem hiding this comment.
I can't go through every file but I did not see any that were deleted that looked like a mistake.
One question: should we remove "refactored" from fcl names since that won't have meaning going forward?
Contributor
Author
|
eventually yes, but for now I would not do it to avoid breaking CI tests and current production configs. Once they all switch to the standard fcls it will be easier to rename |
Contributor
|
Hi @SFBayLaser, @jzennamo: Tracy’s question about the fcl naming was addressed, and there don’t seem to be any concerns about the files being removed. Are we ready to approve this PR? |
SFBayLaser
approved these changes
Apr 23, 2025
Contributor
SFBayLaser
left a comment
SFBayLaser
left a comment
There was a problem hiding this comment.
Yes, I believe this is ready to go
Contributor
|
Trigger build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does 3 things:
Format of fcl files in the standard directory is:
standard_${data/mc}_${workflow}_${step}_icarus.fcl