Skip to content

Conversation

@SFBayLaser
Copy link
Contributor

The gauss hit finder operating on ChannelROIs has moved to sbncode, as well the modules converting from Wire to/from ChannelROI. Removing from icaruscode

Have also added the option to run "GaussHitFinderSBN" which operates from ChannelROI input instead of recob::Wires.

…s well the modules converting from Wire to/from ChannelROI. Removing from icaruscode
@leoaliaga
Copy link
Contributor

@jzennamo, Could you take a look at this PR? Thanks!

@gputnam gputnam requested review from gputnam and removed request for jzennamo May 13, 2025 13:58
Copy link
Contributor

@gputnam gputnam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@leoaliaga
Copy link
Contributor

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_06_00 SBNSoftware/sbnalg@v10_06_00_01 SBNSoftware/sbncode@v10_06_00_01 SBNSoftware/icarus_signal_processing/pull#24

@SBNSoftware SBNSoftware deleted a comment from FNALbuild May 13, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild May 13, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild May 13, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild May 13, 2025
@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@leoaliaga leoaliaga merged commit 845ea09 into develop May 13, 2025
2 of 4 checks passed
@leoaliaga leoaliaga deleted the feature/usher_channelroiupdates branch May 13, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

5 participants