Removing bad channels from use in coherent noise corrections #818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e so they are not used in the computation of the coherent noise factors
… them at this time so let's save output space
…from the bad channel database) and the removal of channels with "bad" truncated RMS values (e.g. too low to be connected and/or too high to be usable).
gputnam
approved these changes
May 9, 2025
Contributor
gputnam
left a comment
gputnam
left a comment
There was a problem hiding this comment.
Approved. Discussions sorted out over slack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update allows the ability to remove "bad" channels (from channels database) from consideration in computing coherent noise subtraction.
This also adds the ability to reject channels that have too low a truncated rms, or too large, so they won't be used either.
Both have fhicl parameters to turn on/off